Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: DevTestLab missing parameter #3056

Closed
1 task done
HexagonSam opened this issue Aug 16, 2024 · 4 comments · Fixed by #3102
Closed
1 task done

[AVM Module Issue]: DevTestLab missing parameter #3056

HexagonSam opened this issue Aug 16, 2024 · 4 comments · Fixed by #3102
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@HexagonSam
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/dev-test-lab/lab

(Optional) Module Version

No response

Description

The DevTestLab lab main bicep does not have a parameter for artifact repo token:

module lab_artifactSources 'artifactsource/main.bicep' = [
  for (artifactSource, index) in artifactsources: {
    name: '${uniqueString(deployment().name, location)}-Lab-ArtifactSources-${index}'
    params: {
      labName: lab.name
      name: artifactSource.name
      tags: artifactSource.?tags ?? tags
      displayName: contains(artifactSource, 'displayName') ? artifactSource.displayName : artifactSource.name
      branchRef: contains(artifactSource, 'branchRef') ? artifactSource.branchRef : ''
      folderPath: contains(artifactSource, 'folderPath') ? artifactSource.folderPath : ''
      armTemplateFolderPath: contains(artifactSource, 'armTemplateFolderPath')
        ? artifactSource.armTemplateFolderPath
        : ''
      sourceType: contains(artifactSource, 'sourceType') ? artifactSource.sourceType : ''
      status: contains(artifactSource, 'status') ? artifactSource.status : 'Enabled'
      uri: artifactSource.uri
    }
  }
]

The artifactsource module it references does contain this parameter available:

@sys.description('Optional. The security token to authenticate to the artifact source.')
@secure()
param securityToken string = ''

Without being able to specify this parameter in the main lab, we can't setup private repos.

(Optional) Correlation Id

No response

@HexagonSam HexagonSam added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 16, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Aug 16, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Aug 16, 2024
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Aug 16, 2024
Copy link

@HexagonSam, thanks for submitting this issue for the avm/res/dev-test-lab/lab module!

Important

A member of the @Azure/avm-res-devtestlab-lab-module-owners-bicep or @Azure/avm-res-devtestlab-lab-module-contributors-bicep team will review it soon!

@ahmadabdalla
Copy link
Contributor

@HexagonSam thank you for raising the issue. We will look into this.

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
2 participants