Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avm/ptn/ai-platform/baseline Fix compute name and VM username for tests #3047

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

cecheta
Copy link
Member

@cecheta cecheta commented Aug 14, 2024

Description

  • Fixes compute name by appending serviceShort (aipbmax) to the compute name
    • Currently, it fails if substring(uniqueString(baseTime), 0, 3) produces three numbers
    • The constraint is:
A name for an Azure ML Compute Instance must be between 3 and 24 characters in length and must use only numbers, letters and minus symbol (-),must start with letters. Numbers cannot be the ending of the name if the previous character is a minus symbol (-). Please specify a different Azure ML Instance name
  • Hardcodes VM username so retries have a greater chance of succeeding, as username cannot be changed once the VM has been created
    • Uses same username as avm/res/compute/virtual-machine module uses in its tests

Pipeline Reference

Pipeline
avm.ptn.ai-platform.baseline

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 14, 2024
@cecheta cecheta marked this pull request as ready for review August 14, 2024 21:26
@cecheta cecheta requested review from a team as code owners August 14, 2024 21:26
@cecheta cecheta merged commit a445890 into Azure:main Aug 15, 2024
4 of 5 checks passed
@cecheta cecheta deleted the compute-name branch August 15, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants