fix: avm/ptn/ai-platform/baseline Fix compute name and VM username …

…for tests
Azure · Aug 14, 2024 · ac5885a · ac5885a
1 parent 001a3e9
commit ac5885a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 22 deletions.
diff --git a/avm/ptn/ai-platform/baseline/README.md b/avm/ptn/ai-platform/baseline/README.md
@@ -107,7 +107,7 @@ module baseline 'br/public:avm/ptn/ai-platform/baseline:<version>' = {
     // Non-required parameters
     virtualMachineConfiguration: {
       adminPassword: '<adminPassword>'
-      adminUsername: '<adminUsername>'
+      adminUsername: 'localAdminUser'
     }
   }
 }
@@ -133,7 +133,7 @@ module baseline 'br/public:avm/ptn/ai-platform/baseline:<version>' = {
     "virtualMachineConfiguration": {
       "value": {
         "adminPassword": "<adminPassword>",
-        "adminUsername": "<adminUsername>"
+        "adminUsername": "localAdminUser"
       }
     }
   }
@@ -196,7 +196,7 @@ module baseline 'br/public:avm/ptn/ai-platform/baseline:<version>' = {
     }
     virtualMachineConfiguration: {
       adminPassword: '<adminPassword>'
-      adminUsername: '<adminUsername>'
+      adminUsername: 'localAdminUser'
       enableAadLoginExtension: true
       enableAzureMonitorAgent: true
       enabled: true
@@ -335,7 +335,7 @@ module baseline 'br/public:avm/ptn/ai-platform/baseline:<version>' = {
     "virtualMachineConfiguration": {
       "value": {
         "adminPassword": "<adminPassword>",
-        "adminUsername": "<adminUsername>",
+        "adminUsername": "localAdminUser",
         "enableAadLoginExtension": true,
         "enableAzureMonitorAgent": true,
         "enabled": true,
@@ -547,7 +547,7 @@ module baseline 'br/public:avm/ptn/ai-platform/baseline:<version>' = {
     }
     virtualMachineConfiguration: {
       adminPassword: '<adminPassword>'
-      adminUsername: '<adminUsername>'
+      adminUsername: 'localAdminUser'
       enableAadLoginExtension: true
       enableAzureMonitorAgent: true
       maintenanceConfigurationResourceId: '<maintenanceConfigurationResourceId>'
@@ -597,7 +597,7 @@ module baseline 'br/public:avm/ptn/ai-platform/baseline:<version>' = {
     "virtualMachineConfiguration": {
       "value": {
         "adminPassword": "<adminPassword>",
-        "adminUsername": "<adminUsername>",
+        "adminUsername": "localAdminUser",
         "enableAadLoginExtension": true,
         "enableAzureMonitorAgent": true,
         "maintenanceConfigurationResourceId": "<maintenanceConfigurationResourceId>",

diff --git a/avm/ptn/ai-platform/baseline/tests/e2e/defaults/main.test.bicep b/avm/ptn/ai-platform/baseline/tests/e2e/defaults/main.test.bicep
@@ -23,10 +23,6 @@ param baseTime string = utcNow('u')
 @description('Optional. A token to inject into the name of each resource.')
 param namePrefix string = '#_namePrefix_#'
 
-@description('Generated. The username to leverage for the login.')
-@secure()
-param username string = uniqueString(newGuid())
-
 @description('Generated. The password to leverage for the login.')
 @secure()
 param password string = newGuid()
@@ -54,7 +50,7 @@ module testDeployment '../../../main.bicep' = [
     params: {
       name: '${namePrefix}${serviceShort}${substring(uniqueString(baseTime), 0, 3)}'
       virtualMachineConfiguration: {
-        adminUsername: username
+        adminUsername: 'localAdminUser'
         adminPassword: password
       }
     }

diff --git a/avm/ptn/ai-platform/baseline/tests/e2e/max/main.test.bicep b/avm/ptn/ai-platform/baseline/tests/e2e/max/main.test.bicep
@@ -23,10 +23,6 @@ param baseTime string = utcNow('u')
 @description('Optional. A token to inject into the name of each resource.')
 param namePrefix string = '#_namePrefix_#'
 
-@description('Generated. The username to leverage for the login.')
-@secure()
-param username string = uniqueString(newGuid())
-
 @description('Generated. The password to leverage for the login.')
 @secure()
 param password string = newGuid()
@@ -115,7 +111,7 @@ module testDeployment '../../../main.bicep' = [
         name: take('${namePrefix}-vm-${serviceShort}', 15)
         zone: 0
         size: 'Standard_DS1_v2'
-        adminUsername: username
+        adminUsername: 'localAdminUser'
         adminPassword: password
         nicConfigurationConfiguration: {
           name: '${namePrefix}-nic-${serviceShort}'
@@ -150,7 +146,7 @@ module testDeployment '../../../main.bicep' = [
         computes: [
           {
             computeType: 'ComputeInstance'
-            name: 'compute-${substring(uniqueString(baseTime), 0, 3)}'
+            name: 'compute-${substring(uniqueString(baseTime), 0, 3)}-${serviceShort}'
             description: 'Default'
             location: resourceLocation
             properties: {

diff --git a/avm/ptn/ai-platform/baseline/tests/e2e/waf-aligned/main.test.bicep b/avm/ptn/ai-platform/baseline/tests/e2e/waf-aligned/main.test.bicep
@@ -24,10 +24,6 @@ param baseTime string = utcNow('u')
 @description('Optional. A token to inject into the name of each resource.')
 param namePrefix string = '#_namePrefix_#'
 
-@description('Generated. The username to leverage for the login.')
-@secure()
-param username string = uniqueString(newGuid())
-
 @description('Generated. The password to leverage for the login.')
 @secure()
 param password string = newGuid()
@@ -65,7 +61,7 @@ module testDeployment '../../../main.bicep' = [
     params: {
       name: '${namePrefix}${serviceShort}${substring(uniqueString(baseTime), 0, 3)}'
       virtualMachineConfiguration: {
-        adminUsername: username
+        adminUsername: 'localAdminUser'
         adminPassword: password
         enableAadLoginExtension: true
         enableAzureMonitorAgent: true