Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated LE for finops module to align with Linux runners #3007

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Update LE for finops
  • Updated .gitattributes

Closes #2653

Pipeline Reference

Pipeline
avm.ptn.finops-toolkit.finops-hub

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr added the Type: Bug 🐛 Something isn't working label Aug 8, 2024
@AlexanderSehr AlexanderSehr self-assigned this Aug 8, 2024
@AlexanderSehr AlexanderSehr added Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: CI 🚀 This issue is related to the AVM CI labels Aug 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still and removed Needs: Triage 🔍 Maintainers need to triage still labels Aug 8, 2024
@AlexanderSehr AlexanderSehr changed the title Updated LE fix: Updated LE for finops modules to align with Linux runners Aug 8, 2024
@AlexanderSehr AlexanderSehr changed the title fix: Updated LE for finops modules to align with Linux runners fix: Updated LE for finops module to align with Linux runners Aug 8, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review August 8, 2024 08:00
@AlexanderSehr AlexanderSehr requested review from a team as code owners August 8, 2024 08:00
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 8, 2024 08:10
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit b684d47 into main Aug 8, 2024
23 of 24 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/lineEnding branch August 8, 2024 11:01
AlexanderSehr added a commit that referenced this pull request Sep 13, 2024
…/azure-image-builder` (#3005)

## Description

This PR introduces the Azure Image Builder pattern to AVM

Depends on
- #3006 
- #3007 
- #2992 
- #2756

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.virtual-machine-images.azure-image-builder](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.ptn.virtual-machine-images.azure-image-builder.yml/badge.svg?branch=users%2Falsehr%2FaibPattern)](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.ptn.virtual-machine-images.azure-image-builder.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Maher Aldineh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.ptn.finops-toolkit.finops-hub
2 participants