fix: Image Template Make customizations optional - avm/res/virtual-machine-images/image-template
#2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
added
Type: AVM 🅰️ ✌️ Ⓜ️
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
auto-merge was automatically disabled
August 8, 2024 06:54
Pull request was converted to draft
Merged
8 tasks
matebarabas
changed the title
customizations optionalcustomizations optional - avm/res/virtual-machine-images/image-template
AlexanderSehr
added
the
Needs: Core Team 🧞
ahmadabdalla
previously approved these changes
Sep 5, 2024
eriqua
reviewed
Sep 6, 2024
avm/res/virtual-machine-images/image-template/tests/e2e/max/dependencies.bicep
Show resolved
Hide resolved
Co-authored-by: Erika Gressi <[email protected]>
eriqua
reviewed
Sep 7, 2024
Co-authored-by: Erika Gressi <[email protected]>
jianingwang123
pushed a commit
to jianingwang123/bicep-registry-modules
that referenced
this pull request
Sep 12, 2024
…-machine-images/image-template` (Azure#2992) ## Description - The `customizations` property is optional in the API and should also be in the module in case somebody just wants to backup a marketplace image - Fix for script upload (prep for Azure#3005) ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.virtual-machine-images.image-template.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation
AlexanderSehr
added a commit
that referenced
this pull request
Sep 13, 2024
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.virtual-machine-images.image-template.yml){kind=link}
…/azure-image-builder` (#3005) ## Description This PR introduces the Azure Image Builder pattern to AVM Depends on - #3006 - #3007 - #2992 - #2756 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.ptn.virtual-machine-images.azure-image-builder.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Maher Aldineh <[email protected]>
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.ptn.virtual-machine-images.azure-image-builder.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
customizationsproperty is optional in the API and should also be in the module in case somebody just wants to backup a marketplace imageavm/ptn/virtual-machine-images/azure-image-builder#3005)Pipeline Reference
Type of Change
version.json:version.json.version.json.