Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1785 output hostnames + feat: #2672 add the output hostname, endpointName, endpointId, uri in CDN Profile Module #2675

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

gbeaud
Copy link
Contributor

@gbeaud gbeaud commented Jul 8, 2024

Description

Adding a set of outputs asked by users (non-breaking changes):

  • hostName
  • endpointName
  • endpointId
  • URI

Pipeline Reference

avm.res.cdn.profile

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@gbeaud gbeaud requested review from a team as code owners July 8, 2024 14:41
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 8, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jul 8, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@gbeaud gbeaud changed the title Feature#1785 output hostnames + Feature#2672 add the output hostname, endpointName, endpointId, uri in CDN Profile Module feat:#1785 output hostnames + feat:#2672 add the output hostname, endpointName, endpointId, uri in CDN Profile Module Jul 8, 2024
@gbeaud gbeaud changed the title feat:#1785 output hostnames + feat:#2672 add the output hostname, endpointName, endpointId, uri in CDN Profile Module feat: #1785 output hostnames + feat: #2672 add the output hostname, endpointName, endpointId, uri in CDN Profile Module Jul 8, 2024
@gbeaud gbeaud added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jul 8, 2024
@eriqua eriqua closed this Jul 8, 2024
@eriqua eriqua reopened this Jul 8, 2024
@eriqua eriqua requested a review from a team as a code owner July 8, 2024 17:43
Copy link
Contributor Author

@gbeaud gbeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok accepting the changes

@AlexanderSehr AlexanderSehr merged commit 3e06684 into Azure:main Jul 10, 2024
5 checks passed
@gbeaud gbeaud deleted the feature#1785-output-hostnames-2 branch November 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants