feat: add the output endpointName, endpointId, uri in CDN Profile Module - avm/res/cdn /profile
#2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
|
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
gbeaud
added a commit
to gbeaud/bicep-registry-modules
that referenced
this pull request
Jul 8, 2024
…rofile Module - avm/res/cdn /profile Azure#2672 + Azure#1785
gbeaud
added a commit
to gbeaud/bicep-registry-modules
that referenced
this pull request
Jul 8, 2024
…rofile Module - avm/res/cdn /profile Azure#2672 + Azure#1785
|
@jianingwang123 thank you so much for your contribution 🙏 I was working on another feature also related to outputs so since your pipeline was failing (according to your badge) I've taken your code, tested it on my side and made a PR with the other feature + this one here: #2675 So we can close this one, again thanks for the help! |
gbeaud
added a commit
to gbeaud/bicep-registry-modules
that referenced
this pull request
Jul 10, 2024
…ostname, endpointName, endpointId, uri in CDN Profile Module Azure#2675
AlexanderSehr
added a commit
that referenced
this pull request
Jul 10, 2024
…ndpointName, endpointId, uri in CDN Profile Module (#2675) ## Description Adding a set of outputs asked by users (non-breaking changes): - hostName - endpointName - endpointId - URI <!-- Closes #1785 Closes #2672 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> [](https://github.com/gbeaud/bicep-registry-modules/actions/workflows/avm.res.cdn.profile.yml) ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Alexander Sehr <[email protected]>
](https://github.com/gbeaud/bicep-registry-modules/actions/workflows/avm.res.cdn.profile.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2610
Pipeline Reference
The reason for the failure of this pipeline is the same as that of the
mainbranch. The error is as follows:Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.@jongio for notification.