Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avm/res/db-for-postgre-sql/flexible-server Add PEs in public mode #2613

Merged
merged 29 commits into from
Oct 14, 2024
Merged

feat: avm/res/db-for-postgre-sql/flexible-server Add PEs in public mode #2613

merged 29 commits into from
Oct 14, 2024

Conversation

donheerschap
Copy link
Contributor

@donheerschap donheerschap commented Jul 3, 2024 •
edited
Loading

Description

Adding possibility to deploy private endpoints when the server is in public mode.
Closes #2578

Pipeline Reference

Pipeline
avm.res.db-for-postgre-sql.flexible-server

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jul 3, 2024
@donheerschap donheerschap mentioned this pull request Jul 3, 2024
Closed
1 task
@donheerschap donheerschap marked this pull request as ready for review July 18, 2024 12:23
@donheerschap donheerschap requested review from a team as code owners July 18, 2024 12:23
@arnoldna arnoldna requested review from arnoldna, AlexanderSehr and eriqua and removed request for arnoldna September 30, 2024 22:42
@AlexanderSehr
Copy link
Contributor

@donheerschap & @arnoldna please note that there are numerous conflicts that prevent the PR from being merged :o

@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 1, 2024
@arnoldna
Copy link
Contributor

arnoldna commented Oct 2, 2024

@donheerschap - Greetings. Will you have time this week to update your pull request to account for the branch conflict? Thanks.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 2, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 2, 2024
@ReneHezser
Copy link
Contributor

ReneHezser commented Oct 4, 2024 •
edited
Loading

@donheerschap
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please update your branch and run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.

Please reach out if any support is needed.

@eriqua eriqua added the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 8, 2024
@eriqua
Copy link
Contributor

eriqua commented Oct 8, 2024

@donheerschap, @arnoldna any update on this PR?
Sorry for chasing, an unfortunate effect of the PR staying open for long is that the chance of getting merge conflicts increases. There are several conflicts already preventing the merge. Would you be able to fix them? Please reach out if any support required 💪

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author label Oct 8, 2024
@eriqua eriqua added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author and removed Needs: Attention 👋 Reply has been added to issue, maintainer to review labels Oct 8, 2024
@donheerschap
Copy link
Contributor Author

@eriqua Solved the merge conflicts, @arnoldna Feel free to re-re-review

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Oct 11, 2024
@arnoldna arnoldna self-requested a review October 14, 2024 13:28
@eriqua eriqua merged commit 7e97126 into Azure:main Oct 14, 2024
4 checks passed
@donheerschap donheerschap deleted the psqlPrivateEndpoint branch October 14, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnoldna arnoldna arnoldna approved these changes

@AlexanderSehr AlexanderSehr Awaiting requested review from AlexanderSehr

@eriqua eriqua Awaiting requested review from eriqua

Assignees

@AlexanderSehr AlexanderSehr

@arnoldna arnoldna

@donheerschap donheerschap

Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: DBforPostgreSQL Flexible Servers Private Endpoints
7 participants
@donheerschap @eriqua @AlexanderSehr @arnoldna @ReneHezser @matebarabas @josearper