[AVM Module Issue]: DBforPostgreSQL Flexible Servers Private Endpoints #2578
Comments
sam-bryant
added
Needs: Triage 🔍
|
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
microsoft-github-policy-service
bot
added
the
Type: Feature Request ➕
|
@sam-bryant, thanks for submitting this issue for the Important A member of the @Azure/avm-res-dbforpostgresql-flexibleserver-module-owners-bicep or @Azure/avm-res-dbforpostgresql-flexibleserver-module-contributors-bicep team will review it soon! |
|
@josearper I made a draft #2613 which contains changes that would fix this issue. The pipeline fails because of subscriptions limits after a few deployments. Besides PSrule failed on defaults e2e tests on settings which shouldn't be in the defaults IMHO, but I added them (for ex. highAvailability) to let validation pass. @sam-bryant Out of curiosity why not "just" use private mode with a delegated subnet? |
|
@donheerschap - I think you are right that I should just be using that. This a new resource for us and I was hacking at it manually via the portal and noticed the private endpoint options and couldn't translate that into the module definition. I think I crossed some wires that led me down this route. |
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
microsoft-github-policy-service
bot
added
the
Status: Response Overdue 🚩
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
microsoft-github-policy-service
bot
added
the
Needs: Immediate Attention ‼️
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
|
Hey @josearper, could you please take a look and triage the issue at your earliest convenience? 💪 |
|
As far as I'm concerned you could probably disregard this. At the moment we are paused on our direction with this and might be going a different direction altogether. I apologize for any inconveniences. Thank you for the analysis so far. |
|
Hey @sam-bryant, given that there is already a PR, it would be a shame not to see it through though 😉 |
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
|
Warning Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly. Tip
|
|
Caution **This issue requires the AVM Core Team's (@Azure/avm-core-team-technical-bicep) immediate attention as it hasn't been responded to within 6 business days. ** Tip
|
arnoldna
removed
Needs: Triage 🔍
…mode (#2613) ## Description <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. --> Adding possibility to deploy private endpoints when the server is in public mode. Closes [#2578](#2578) ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/donheerschap/bicep-registry-modules/actions/workflows/avm.res.db-for-postgre-sql.flexible-server.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Nate Arnold <[email protected]>
](https://github.com/donheerschap/bicep-registry-modules/actions/workflows/avm.res.db-for-postgre-sql.flexible-server.yml){kind=link}
github-project-automation
bot
moved this from Needs: Triage
to Done
in AVM - Module Issues
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/db-for-postgre-sql/flexible-server
(Optional) Module Version
No response
Description
This module does not appear to have the privateEndpoints parameter found in other modules. I apologize if I'm missing something.
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: