Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: res/web/connection parameter update #2466

Merged
merged 15 commits into from
Jun 27, 2024

Conversation

ReneHezser
Copy link
Contributor

Description

Added the parameterValueSet parameter and some documentation improvements.

Closes #2338

Pipeline Reference

Pipeline
avm.res.web.connection

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@ReneHezser ReneHezser requested review from a team as code owners June 18, 2024 08:41
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jun 18, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jun 18, 2024
@ReneHezser
Copy link
Contributor Author

The workflow just finished successfully again.

@matebarabas matebarabas added Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 19, 2024
@AlexanderSehr
Copy link
Contributor

@krbar, please take a final look and approve/comment? 💪 :)

Copy link
Contributor

@krbar krbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @ReneHezser for this contribution and @AlexanderSehr for your review.

@krbar krbar merged commit e618879 into Azure:main Jun 27, 2024
4 checks passed
@ReneHezser ReneHezser deleted the web-connections-update branch June 27, 2024 09:57
@ReneHezser ReneHezser restored the web-connections-update branch June 27, 2024 10:05
@ReneHezser ReneHezser deleted the web-connections-update branch June 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
4 participants