Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Microsoft.Web/connections, need parameterValueSet for deploying service bus type API Connection #2338

Closed
1 task done
DJHaose opened this issue Jun 12, 2024 · 5 comments · Fixed by #2466
Assignees
Labels
Class: Resource Module 📦 This is a resource module Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@DJHaose
Copy link

DJHaose commented Jun 12, 2024

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/web/connection

(Optional) Module Version

0.1.0

Description

Using Chrome developer tool to see the payload sent in JSON when creating an API connection that's service bus type. Similar to this Q&A https://learn.microsoft.com/en-us/answers/questions/1427460/how-to-paramatize-service-bus-managed-identity-in

We need either an additional properties parameter or a parmeterValueSet parmeter. Currently there are customParameterValues, nonSecretParameterValues and parameterValues non of them fulfils that parameterValueSet under properties.

{
  "type": "Microsoft.Web/connections",
  "apiVersion": "2016-06-01",
  "name": "[parameters('connections_servicebus_name')]",
  "location": "[parameters('location')]",
  "kind": "V2",
  "properties": {
      "api": {
          "id": "[concat('/subscriptions/', parameters('subscriptionId'), '/providers/Microsoft.Web/locations/', parameters('location'), '/managedApis/servicebus')]"
      },
      "parameterValueSet": {
          "name": "managedIdentityAuth",
          "values": {
              "namespaceEndpoint": {
              "value": "[concat('sb://', parameters('servicebus_namespace'), '.servicebus.windows.net/')]"
              }
          }
      },
      "displayName": "[parameters('connections_servicebus_name')]"
  }
}

(Optional) Correlation Id

No response

@DJHaose DJHaose added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jun 12, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Jun 12, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Jun 12, 2024
Copy link

@DJHaose, thanks for submitting this issue for the avm/res/web/connection module!

Important

Please note, that this module is currently orphaned. The @Azure/avm-core-team-technical-bicep, will attempt to find an owner for it. In the meantime, the core team may assist with this issue. Thank you for your patience!

@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Jun 12, 2024
@matebarabas
Copy link
Contributor

This module is currently orphaned: Azure/Azure-Verified-Modules#767

@matebarabas matebarabas added Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time and removed Needs: Triage 🔍 Maintainers need to triage still labels Jun 13, 2024
@ReneHezser ReneHezser self-assigned this Jun 13, 2024
@ReneHezser
Copy link
Contributor

Hi @DJHaose,
if it is just the missing parameter, we can implement it. I'd like to add an example of a Service Bus connection to the documentation. Would you mind providing a complete example of your scenario?

@ReneHezser
Copy link
Contributor

A request to add the property has already been created here: Azure/bicep-types-az#1812

@krbar krbar closed this as completed in e618879 Jun 27, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Jun 27, 2024
@github-project-automation github-project-automation bot moved this from Needs: Triage to Done in AVM - Module Issues Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Status: Module Orphaned 👀 The module has no owner and is therefore orphaned at this time Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants