Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new allowable values for licenseType - RHEL_BYOS / SLES_BYOS #1769

Merged
merged 9 commits into from
Apr 30, 2024
Merged

fix: add new allowable values for licenseType - RHEL_BYOS / SLES_BYOS #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
99db6d2
Add RHEL_BYOS as allowed valuef or licenseType parameter
oramoss Apr 12, 2024
d83fc5d
Updated to include SLES_BYOS
oramoss Apr 15, 2024
6b077e0
Update README documentation
oramoss Apr 15, 2024
99390f6
Change backup service GUID to test in my tenant
oramoss Apr 24, 2024
e02ee2b
Temporary change to NVidia SKU to get test to build
oramoss Apr 25, 2024
ad2f47c
Update README to reference new NVidia SKU correctly.
oramoss Apr 25, 2024
565c8cf
Revert temporary changes that facilitate test pack
oramoss Apr 26, 2024
b993c76
Merge branch 'main' of github.com:oramoss/bicep-registry-modules
oramoss Apr 27, 2024
0a29c40
Merge branch 'main' into feature/licenseType
rahalan Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions avm/res/compute/virtual-machine/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3736,6 +3736,8 @@ Specifies that the image or disk that is being used was licensed on-premises.
```Bicep
[
''
'RHEL_BYOS'
'SLES_BYOS'
'Windows_Client'
'Windows_Server'
]
Expand Down
2 changes: 2 additions & 0 deletions avm/res/compute/virtual-machine/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ param dedicatedHostId string = ''

@description('Optional. Specifies that the image or disk that is being used was licensed on-premises.')
@allowed([
'RHEL_BYOS'
'SLES_BYOS'
'Windows_Client'
'Windows_Server'
''
Expand Down
54 changes: 28 additions & 26 deletions avm/res/compute/virtual-machine/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,8 @@
"type": "string",
"defaultValue": "",
"allowedValues": [
"RHEL_BYOS",
"SLES_BYOS",
"Windows_Client",
"Windows_Server",
""
Expand Down Expand Up @@ -2710,8 +2712,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -2916,8 +2918,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -3118,8 +3120,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -3332,8 +3334,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -3535,8 +3537,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -3732,8 +3734,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -3933,8 +3935,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -4142,8 +4144,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -4343,8 +4345,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -4542,8 +4544,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -4752,8 +4754,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -4952,8 +4954,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "16251967456691023698"
"version": "0.26.170.59819",
"templateHash": "8063436714999902780"
},
"name": "Virtual Machine Extensions",
"description": "This module deploys a Virtual Machine Extension.",
Expand Down Expand Up @@ -5151,8 +5153,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.26.54.24096",
"templateHash": "5385249890312845255"
"version": "0.26.170.59819",
"templateHash": "2393851439891433510"
},
"name": "Recovery Service Vaults Protection Container Protected Item",
"description": "This module deploys a Recovery Services Vault Protection Container Protected Item.",
Expand Down