Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor bugs in worflow automation regarding failed pipelines #1751

Merged
merged 48 commits into from
Apr 26, 2024

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Apr 25, 2024

Fixes:

  • not the full team of the bicep team was used, making the @ mentioning not working
  • wrong comment was created, regarding the owner, if owner assignment failed due to GH bug

@rahalan rahalan added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: Hygiene 🧹 things related to testing, issue triage etc. labels Apr 25, 2024
@rahalan rahalan self-assigned this Apr 25, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 25, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

Note

This label was added as per ITA06.

Note

The "Needs: Triage 🔍" label was removed as per ITA15.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Triage 🔍 Maintainers need to triage still label Apr 25, 2024
@rahalan rahalan marked this pull request as ready for review April 25, 2024 15:31
@rahalan rahalan requested a review from a team as a code owner April 25, 2024 15:31
@rahalan rahalan enabled auto-merge (squash) April 25, 2024 15:31
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@rahalan rahalan merged commit bba0279 into Azure:main Apr 26, 2024
4 checks passed
@rahalan rahalan deleted the users/rahalan/FixAutomationWorkflows4 branch April 26, 2024 11:26
donk-msft pushed a commit to donk-msft/bicep-registry-modules that referenced this pull request Apr 29, 2024
…re#1751)

Fixes:
- not the full team of the bicep team was used, making the @ mentioning
not working
- wrong comment was created, regarding the owner, if owner assignment
failed due to GH bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: Hygiene 🧹 things related to testing, issue triage etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants