Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrated BRM with AVM workflows #1411

Merged
merged 145 commits into from
Apr 25, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Mar 25, 2024

Description

  • Aligned workflow file prefix to platform.*
  • Aligned workflow naming to Platform -
  • Retired workflows that have been used by the /modules folder
  • TODO: Cleanup BRM scripts folder

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr marked this pull request as ready for review April 2, 2024 15:40
@AlexanderSehr AlexanderSehr requested review from a team as code owners April 2, 2024 15:40
@AlexanderSehr AlexanderSehr requested a review from eriqua April 2, 2024 15:40
@AlexanderSehr AlexanderSehr added Status: Help Wanted 🆘 Extra attention is needed and removed Status: Do Not Merge ⛔ Do not merge PRs with this label attached as they are not ready or aligned to future direction etc. labels Apr 2, 2024
@AlexanderSehr AlexanderSehr removed the Status: Help Wanted 🆘 Extra attention is needed label Apr 20, 2024
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 20, 2024 07:50
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 2cb3048 into Azure:main Apr 25, 2024
5 checks passed
donk-msft pushed a commit to donk-msft/bicep-registry-modules that referenced this pull request Apr 29, 2024
## Description

- Aligned workflow file prefix to `platform.*` 
- Aligned workflow naming to `Platform -` 
- Retired workflows that have been used by the `/modules` folder
- [x] TODO: Cleanup BRM scripts folder

## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

---------

Co-authored-by: Erika Gressi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants