Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report]: virtual-network does not exist #128

Closed
dciborow opened this issue Jul 28, 2022 · 1 comment
Closed

[Bug Report]: virtual-network does not exist #128

dciborow opened this issue Jul 28, 2022 · 1 comment

Comments

@dciborow
Copy link
Contributor

Module path

/modules/network/virtual-network/

Bicep version

1.0

Describe the bug

Error BCP192: Unable to restore the module with reference "br:mcr.microsoft.com/bicep/network/virtual-network:1.0": The module does not exist in the registry.

To reproduce

This is reproduced in this PR here, which tries to use this module.
Azure/azure-quickstart-templates#12704

Code snippet

module vnet 'br/public:network/virtual-network:1.0' = {
  name: vnetName
  location: location
  params: {
    name: vnetName
    addressPrefixes: vnetAddressPrefix
    subnets: [
      {
        name                             : subnetName        
        addressPrefix                    : subnetAddressPrefix
        privateEndpointNetworkPolicies   : 'Disabled'
        privateLinkServiceNetworkPolicies: 'Enabled'
        networkSecurityGroupId           : networkSecurityGroup.id
      }
    ]
  }
}

Relevant log output

+ CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
+ FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Validate-DeploymentFile.ps1
D:\a\1\test\ci-scripts\Validate-DeploymentFile.ps1 : D:\a\1\s\application-workloads\azure-gamedev\gamedev-vmss\nestedtemplates\virtualNetworks.bicep(14,13) : Error BCP192: Unable to restore the module with reference "br:mcr.microsoft.com/bicep/network/virtual-network:1.0": The module does not exist in the registry.
At D:\a\_temp\d5ef0165-5965-4bc0-8da6-717f071a6137.ps1:3 char:1
+ . 'D:\a\1\test\ci-scripts\Validate-DeploymentFile.ps1'
@ghost ghost added the Needs: Triage 🔍 Maintainers need to triage still label Jul 28, 2022
@shenglol shenglol removed the Needs: Triage 🔍 Maintainers need to triage still label Jul 28, 2022
@shenglol
Copy link
Contributor

Can you use br/public:network/virtual-network:1.0.2? The version must include the patch version number. This is a mistake in the README file. I'll fix it later.

@dciborow dciborow mentioned this issue Aug 2, 2022
13 tasks
AlexanderSehr added a commit that referenced this issue Jan 29, 2024
## Description

<!--Why this PR? What is changed? What is the effect? etc.-->

Closes avm/res/app/container-app
[#128](Azure/Azure-Verified-Modules#128 (comment))

If you haven't already, read the full [contribution
guide](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md).
The guide may have changed since the last time you read it, so please
double-check. Once you are done and ready to submit your PR, edit the PR
description and run through the relevant checklist below.

Enable GitHub Workflows in your fork to enable auto-generation of assets
with our [GitHub Action](/.github/workflows/push-auto-generate.yml).
To trigger GitHub Actions after auto-generation, [add a GitHub
PAT](https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token)
as a secret in your forked repository called `PAT`.

> edit: @AlexanderSehr 
> | Pipeline |
> | - |
> |
[![avm.res.app.container-app](https://github.com/oZakari/bicep-registry-modules/actions/workflows/avm.res.app.container-app.yml/badge.svg?branch=container-apps&event=workflow_dispatch)](https://github.com/oZakari/bicep-registry-modules/actions/workflows/avm.res.app.container-app.yml)
|

## Adding a new module

<!--Run through the checklist if your PR adds a new module.-->

- [x] A proposal has been submitted and approved.
- [x] I have included "Closes #{module_proposal_issue_number}" in the PR
description.
- [ ] I have run `brm validate` locally to verify the module files.
- [x] I have run deployment tests locally to ensure the module is
deployable.

---------

Co-authored-by: Alexander Sehr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants