adding azure gaming: gdvmss

[dciborow]

Description

Closes #121
If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, edit the PR description and run through the relevant checklist below.

Adding a new module

• A proposal has been submitted and approved.
• I have included "Closes #{module_proposal_issue_number}" in the PR description.
• I have run brm validate locally to verify the module files.
• I have run deployment tests locally to ensure the module is deployable.

Updating an existing module

• This is a bug fix:
  • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
  • The bug was found by the module author, and no one has opened an issue to report it yet.
• I have run brm validate locally to verify the module files.
• I have run deployment tests locally to ensure the module is deployable.
• I have read the Updating an existing module section in the contributing guide and updated the version.json file properly:
  • The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json.
  • The PR contains backwards compatible feature updates, and I have bumped the MINOR version in version.json.
  • The PR contains breaking changes, and I have bumped the MAJOR version in version.json.

[dciborow]

#121

[dciborow]

Closes #121

[dciborow]

@bmoore-msft , in order to run the tests I need to have the VM Offer approved.

publisher='microsoft-azure-gaming' offer = 'game-dev-vm', sku = 'win10_unreal_4_27_2'

[shenglol]

@dciborow Give me some time to accept the legal terms of the image on the subscription, which should fix the test failure.

[shenglol]

@dciborow Do you mind taking a look at #121 (comment)?

[dciborow]

@shenglol , this is ready for review

[shenglol]

@dciborow Posting the question that Alex asked in the module proposal here in case you missed it:

[shenglol]

@alex-frankel Are we good with the changes? If yes, I can start the MCR manifest onboarding process.

[alex-frankel]

Have a small change, but it is not blocking and can happen later.

Can we take an action item to further debug why the vnet module was not working? Maybe myself, @dciborow, @MrMCake can all sit down together and see if we can figure it out? I'd really like to move back to the vnet module in the registry at some point.

[dciborow]

@alex-frankel , we fixed it. this now uses the module, (but still within my own virtualNetwork.bicep)

[alex-frankel]

Thanks! @shenglol this is ready to merge from my perspective