[AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' #1130
Comments
Menghua1
added
Needs: Triage 🔍
microsoft-github-policy-service
bot
added
Needs: Attention 👋
|
@Menghua1, thanks for submitting this issue for the A member of the @azure/avm-res-insights-component-module-owners-bicep or @azure/avm-res-insights-component-module-contributors-bicep team will review it soon! |
…ule (#1137) ## Description Added a new output `connectionString` to the App Insights module. This change has been requested via #1130 , however the issue contains one more request, therefore not closing the issue automatically from here. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #123 Fixes #456 Closes #123 Closes #456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
microsoft-github-policy-service
bot
added
the
Status: Response Overdue 🚩
AlexanderSehr
removed
Needs: Triage 🔍
…ule (Azure#1137) ## Description Added a new output `connectionString` to the App Insights module. This change has been requested via Azure#1130 , however the issue contains one more request, therefore not closing the issue automatically from here. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes Azure#123 Fixes Azure#456 Closes Azure#123 Closes Azure#456 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
|
@krbar Do you have an ETA for this? |
|
The issue of the output parameters |
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.component.yml){kind=link}
|
This issue is fixing by pr: #2016. |
Menghua1
changed the title
|
Dear @Menghua1, please note that after merging the PR 2016 the following resource modules are now available: If I understand correctly, you need a pattern module that deploys these resources together. Can you confirm? If yes, please be aware that this will require a separate module proposal for the new pattern, which you can submit here. This proposal needs a module owner responsible for developing and maintaining the module. While we can assist with the initial development, we cannot take on ownership of this module. Would you or someone from your team be willing to own it? If so, do you need help with the initial development? |
|
@jongio Do you have any ideas? Now, as the |
|
Let's keep that in azure-dev repo for now and take the pattern modules as a separate effort. |
|
@jongio we have opened a new Module Proposal issue here: Azure/Azure-Verified-Modules#1206. If there are no problems, we will close this issue. |
|
Ok |
github-project-automation
bot
moved this from Needs: Triage
to Done
in AVM - Module Issues
Check for previous/existing GitHub issues
Issue Type?
Feature Request
Module Name
avm/res/insights/component
(Optional) Module Name if not listed above
avm/res/insights/component
(Optional) Module Version
No response
Description
Please add the creation of
Microsoft.Portal/dashboardsand the outputapplicationInsights.properties.ConnectionString.For example (azd):
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights.bicep#L19
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights.bicep#L28
CC: @jongio
(Optional) Correlation Id
No response
The text was updated successfully, but these errors were encountered: