Update the infra/core modules to AVM modules of "todo-csharp-sql" #3620
Conversation
templates/todo/projects/csharp-sql/.repo/bicep/infra/main.bicep
Outdated
Show resolved
Hide resolved
|
@jongio According to your comments, the code has been changed. Please review again, thanks. |
| resource restApi 'Microsoft.ApiManagement/service/apis@2021-12-01-preview' existing = { | ||
| name: apiName | ||
| parent: apimService | ||
| } | ||
|
|
||
| resource apiDiagnostics 'Microsoft.ApiManagement/service/apis/diagnostics@2021-12-01-preview' = { |
There was a problem hiding this comment.
I may have asked this before but, I'm wondering why this type apimanagement/service/apis/diag isn't in infra/core.
There was a problem hiding this comment.
I may have asked this before but, I'm wondering why this type apimanagement/service/apis/diag isn't in infra/core.
This apimanagement/service/apis/diag is not originally in infra/core, but in app/apim-api.bicep, and there is no equivalent function in AVM. We have already sent an AVM issue: Azure/bicep-registry-modules#1124.
| name: 'keyvault' | ||
| scope: rg | ||
| params: { | ||
| name: !empty(keyVaultName) ? keyVaultName : '${abbrs.keyVaultVaults}${resourceToken}' | ||
| location: location | ||
| tags: tags | ||
| principalId: principalId |
There was a problem hiding this comment.
How will user be able to run the app locally without this?
There was a problem hiding this comment.
I added permissions elsewhere instead, the link is here: https://github.com/Azure/azure-dev/pull/3620/files/a35fc18c3ab15d73fc88c49fd0ccb75fc029eb82#diff-f1fba4c513e3fd25a2a0c835cbfe410e23057d6680763ac3f0bd1ebdf630b8abR132.
If you want to add the permission of principalId at the current location, it is also possible. We can modify the relevant code to complete it.
Menghua1
changed the title
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/3620You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/3620View Changes | Compare Changes |
Update the infra/core modules to AVM modules for
todo-csharp-sql.1. Modules not replaced by AVM
Microsoft.Portal/dashboards.AVM issue link: [AVM Module Issue]: Application Insight Module should add the creation of 'Microsoft.Portal/dashboards' bicep-registry-modules#1130
Microsoft.ApiManagement/service/loggersandMicrosoft.ApiManagement/service/apis/diagnostics.AVM issue link: [AVM Module Issue]: API Management Module should add the creation of 'Microsoft.ApiManagement/service/loggers' and 'Microsoft.ApiManagement/service/apis/diagnostics' bicep-registry-modules#1124
2. Modules replaced by AVM
@jongio for notification.