-
Notifications
You must be signed in to change notification settings - Fork 377
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Add support for CI secret (#3507)
## Description Added CI secret and updated tests. ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.fabric.capacity](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.fabric.capacity.yml/badge.svg?branch=fix%2Fissues%2Ffabric_admin)](https://github.com/hundredacres/bicep-registry-modules/actions/workflows/avm.res.fabric.capacity.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [X] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [X] I'm sure there are no other open Pull Requests for the same update/change - [X] I have run `Set-AVMModule` locally to generate the supporting module files. - [X] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Máté Barabás <[email protected]> Co-authored-by: Rainer Halanek <[email protected]> Co-authored-by: JFolberth <[email protected]>
- Loading branch information
1 parent
11fce93
commit cab8eda
Showing
5 changed files
with
21 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -42,7 +42,7 @@ module capacity 'br/public:avm/res/fabric/capacity:<version>' = { | |
params: { | ||
// Required parameters | ||
adminMembers: [ | ||
'[email protected]' | ||
'<adminMembersSecret>' | ||
] | ||
name: 'fcmin001' | ||
// Non-required parameters | ||
|
@@ -66,7 +66,7 @@ module capacity 'br/public:avm/res/fabric/capacity:<version>' = { | |
// Required parameters | ||
"adminMembers": { | ||
"value": [ | ||
"[email protected]" | ||
"<adminMembersSecret>" | ||
] | ||
}, | ||
"name": { | ||
|
@@ -92,7 +92,7 @@ using 'br/public:avm/res/fabric/capacity:<version>' | |
// Required parameters | ||
param adminMembers = [ | ||
'[email protected]' | ||
'<adminMembersSecret>' | ||
] | ||
param name = 'fcmin001' | ||
// Non-required parameters | ||
|
@@ -117,7 +117,7 @@ module capacity 'br/public:avm/res/fabric/capacity:<version>' = { | |
params: { | ||
// Required parameters | ||
adminMembers: [ | ||
'[email protected]' | ||
'<adminMembersSecret>' | ||
] | ||
name: 'fcwaf001' | ||
// Non-required parameters | ||
|
@@ -142,7 +142,7 @@ module capacity 'br/public:avm/res/fabric/capacity:<version>' = { | |
// Required parameters | ||
"adminMembers": { | ||
"value": [ | ||
"[email protected]" | ||
"<adminMembersSecret>" | ||
] | ||
}, | ||
"name": { | ||
|
@@ -171,7 +171,7 @@ using 'br/public:avm/res/fabric/capacity:<version>' | |
// Required parameters | ||
param adminMembers = [ | ||
'[email protected]' | ||
'<adminMembersSecret>' | ||
] | ||
param name = 'fcwaf001' | ||
// Non-required parameters | ||
|
@@ -196,7 +196,7 @@ param skuName = 'F64' | |
| Parameter | Type | Description | | ||
| :-- | :-- | :-- | | ||
| [`enableTelemetry`](#parameter-enabletelemetry) | bool | Enable/Disable usage telemetry for module. | | ||
| [`location`](#parameter-location) | string | Location for all Resources. | | ||
| [`location`](#parameter-location) | string | Location for all resources. | | ||
| [`skuName`](#parameter-skuname) | string | SKU tier of the Fabric resource. | | ||
| [`skuTier`](#parameter-skutier) | string | SKU name of the Fabric resource. | | ||
| [`tags`](#parameter-tags) | object | Tags of the resource. | | ||
|
@@ -225,7 +225,7 @@ Enable/Disable usage telemetry for module. | |
|
||
### Parameter: `location` | ||
|
||
Location for all Resources. | ||
Location for all resources. | ||
|
||
- Required: No | ||
- Type: string | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,11 @@ param serviceShort string = 'fcmin' | |
@description('Optional. A token to inject into the name of each resource. This value can be automatically injected by the CI.') | ||
param namePrefix string = '#_namePrefix_#' | ||
|
||
@description('Required. Email address used by resource. This value is tenant-specific and must be stored in the CI Key Vault in a secret named \'CI-adminMembersSecret\'.') | ||
@secure() | ||
param adminMembersSecret string = '' | ||
|
||
|
||
// ============ // | ||
// Dependencies // | ||
// ============ // | ||
|
@@ -44,7 +49,7 @@ module testDeployment '../../../main.bicep' = [ | |
name: '${namePrefix}${serviceShort}001' | ||
location: resourceLocation | ||
adminMembers: [ | ||
'[email protected]' | ||
adminMembersSecret | ||
] | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,6 +20,10 @@ param serviceShort string = 'fcwaf' | |
@description('Optional. A token to inject into the name of each resource. This value can be automatically injected by the CI.') | ||
param namePrefix string = '#_namePrefix_#' | ||
|
||
@description('Required. Email address used by resource. This value is tenant-specific and must be stored in the CI Key Vault in a secret named \'CI-adminMembersSecret\'.') | ||
@secure() | ||
param adminMembersSecret string = '' | ||
|
||
// ============ // | ||
// Dependencies // | ||
// ============ // | ||
|
@@ -45,7 +49,7 @@ module testDeployment '../../../main.bicep' = [ | |
location: resourceLocation | ||
skuName: 'F64' | ||
adminMembers: [ | ||
'[email protected]' | ||
adminMembersSecret | ||
] | ||
} | ||
} | ||
|