Initial changes on replace master link with release tag. #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-android
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-c
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-cpp
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-go
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-ios
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-android
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-c
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-cpp
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-go
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-ios
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Aug 27, 2020
This was referenced Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Aug 27, 2020
azure-sdk
added a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Aug 27, 2020
weshaggard
reviewed
Aug 27, 2020
weshaggard
reviewed
Aug 27, 2020
weshaggard
reviewed
Aug 27, 2020
weshaggard
reviewed
Aug 27, 2020
mitchdenny
requested changes
Sep 3, 2020
…o release_tag_replacement
|
azure-sdk-tools - sync - eng-common |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
reviewed
Sep 3, 2020
| @@ -451,7 +451,12 @@ function RetrievePackages($pkgRepository, $artifactLocation) { | |||
| exit(1) | |||
| } | |||
| } | |||
| $pkgs = Get-ChildItem -Path $artifactLocation -Include $packagePattern -Recurse -File | |||
| $file_regex = if (!$pkgName) { | |||
There was a problem hiding this comment.
I found js is having multiple packages under artifacts. We need to filter out the one we use.
Checked it here: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=522770&view=artifacts&type=publishedArtifacts
There was a problem hiding this comment.
this isn't exactly a regex so the name is a little miss-leading. I would instead do something like:
if (!$pkgName) {
$packagePattern = $pkgName + $packagePattern
}
weshaggard
reviewed
Sep 3, 2020
mitchdenny
approved these changes
Sep 3, 2020
sima-zhu
force-pushed
the
release_tag_replacement
branch
from
f025d76 to
3c2d23d
Compare
weshaggard
reviewed
Sep 3, 2020
Co-authored-by: Wes Haggard <[email protected]>
weshaggard
reviewed
Sep 3, 2020
weshaggard
reviewed
Sep 3, 2020
weshaggard
approved these changes
Sep 3, 2020
|
@sima-zhu please be sure to go and clean-up your test branches and test pipelines. |
This was referenced Sep 21, 2020
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
) The documentation got modified previosly by 2d589c9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET:
test pipeline
Doc.MS PR
github io 1
github io 2
Python:
test pipeline
Doc.MS PR
github io
Java:
test pipeline
Doc.MS PR
github io
JS:
test pipeline
github io
Doc.MS PR