Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Docs.MS CI needs updated name of exclude_path instead of excludePath #1196

Closed
wants to merge 1 commit into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 11, 2020

Updates what we write to the ci-config json from excludePath to exclude_path within the individual package specification.

@scbedd scbedd requested a review from a team as a code owner November 11, 2020 20:05
@scbedd
Copy link
Member Author

scbedd commented Nov 11, 2020

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@@ -81,7 +81,7 @@ function UpdateParamsJsonPython($pkgs, $ciRepo, $locationInDocRepo){
install_type = "pypi"
name=$releasingPkg.PackageId
}
excludePath = @("test*","example*","sample*","doc*")
exclude_path = @("test*","example*","sample*","doc*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious is this a bug or does python CI make this change recently?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently.

@scbedd scbedd closed this Nov 18, 2020
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants