Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Update-python-CIConfig #15379

Merged

Conversation

chidozieononiwu
Copy link
Member

@chidozieononiwu chidozieononiwu commented Nov 18, 2020

  • Move UpdateParamsJsonPython from https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/scripts/update-docs-ci.ps1 to LanguageSettings.ps1.
  • Rename function to Update-python-CIConfig
  • Add default $monikerId=$null argument to help function reuse across the languages.
  • Switch from BuildNumber to BuildID for test release version.

install_type = "pypi"
name=$releasingPkg.PackageId
}
excludePath = @("test*","example*","sample*","doc*")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're updating this. Can you change this to exclude_path instead of excludePath?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this with at least a local run of the script as the release would actually execute. This looks fine but it's easy to miss run-time bugs.

The plan is to merge the actual update to the call of this new function in the common docs-ci script right?

install_type = "pypi"
name=$releasingPkg.PackageId
}
excludePath = @("test*","example*","sample*","doc*")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scbedd
scbedd previously approved these changes Nov 18, 2020
@chidozieononiwu
Copy link
Member Author

/check-enforcer override

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@chidozieononiwu chidozieononiwu merged commit 7bc5cdf into Azure:master Nov 18, 2020
iscai-msft added a commit that referenced this pull request Nov 19, 2020
…into feature/textanalytics5.2

* 'master' of https://github.com/Azure/azure-sdk-for-python: (40 commits)
  Sync eng/common directory with azure-sdk-tools for PR 1203 (#15441)
  [ServiceBus] Graceful noops for methods taking empty lists. (#15286)
  [text analytics] add sample stories and improve documents (#15429)
  [ServiceBus] Enable FQDNs and connection strings to support newlines and protocol prefixing (e.g. sb://) (#15212)
  Fix combined session+auto-auto_lock_renewer+receive-and-delete mode issue where registry would fail during receipt.  Add tests and changelog entry. (#15343)
  Add Update-python-CIConfig (#15379)
  Remove aiodns from our CI (#15424)
  Resolve Broken Portal Link (#15431)
  [Key Vault] Update tests which disable soft-delete (#15352)
  switching order on readme (#15426)
  [text analtyics] add abby as codeowner (#15376)
  test (#15402)
  fix iothub version (#15405)
  [T2] Batch (#14757)
  [T2] Policyinsights (#14794)
  [T2] apimanagement Wave3 (#14804)
  [T2] devtestlabs Wave3 (#14795)
  [T2]eventgrid wave3 (#14805)
  [T2] Search (#14823)
  test,version,CHANGELOG (#14838)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants