Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose DataAsset class publicly #34814

Merged
merged 6 commits into from
Mar 19, 2024
Merged

fix: Expose DataAsset class publicly #34814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8e6559e
fix: Expose DataAsset class publicly
kdestin Mar 18, 2024
1dd6ea6
doc: Fix DataAsset docstring
kdestin Mar 18, 2024
587fa99
refactor: Make DataAsset params keyword only
kdestin Mar 18, 2024
68bd573
refactor: Remove kwargs from model
kdestin Mar 18, 2024
d876db0
refactor: Remove unused pylint directive
kdestin Mar 18, 2024
8466eda
docs: Update typing in docstring
kdestin Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
from ._deployment.batch_job import BatchJob
from ._deployment.code_configuration import CodeConfiguration
from ._deployment.container_resource_settings import ResourceSettings
from ._deployment.data_asset import DataAsset
from ._deployment.data_collector import DataCollector
from ._deployment.deployment_collection import DeploymentCollection
from ._deployment.deployment_settings import BatchRetrySettings, OnlineRequestSettings, ProbeSettings
Expand Down Expand Up @@ -449,6 +450,7 @@
"ModelPerformanceRegressionThresholds",
"DataCollector",
"IntellectualProperty",
"DataAsset",
"DeploymentCollection",
"RequestLogging",
"NoneCredentialConfiguration",
Expand Down
19 changes: 7 additions & 12 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_deployment/data_asset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# ---------------------------------------------------------

from typing import Any, Dict, Optional
from typing import Dict, Optional

from azure.ai.ml._schema._deployment.online.data_asset_schema import DataAssetSchema
from azure.ai.ml._utils._experimental import experimental
Expand All @@ -13,25 +13,20 @@
class DataAsset:
"""Data Asset entity

:param data_id: Arm id of registered data asset
:param data_id: str
:param name: Name of data asset
:type name: str
:param path: Path where the data asset is stored.
:type path: str
:param version: Version of data asset.
:type version" int

:keyword Optional[str] data_id: Arm id of registered data asset
:keyword Optional[str] name: Name of data asset
:keyword Optional[str] path: Path where the data asset is stored.
:keyword Optional[int] version: Version of data asset.
"""

def __init__(
self,
*,
data_id: Optional[str] = None,
name: Optional[str] = None,
path: Optional[str] = None,
version: Optional[int] = None,
**kwargs: Any,
): # pylint: disable=unused-argument
):
self.data_id = data_id
self.name = name
self.path = path
Expand Down