Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Expose DataAsset class publicly #34814

Merged
merged 6 commits into from
Mar 19, 2024
Merged

fix: Expose DataAsset class publicly #34814

merged 6 commits into from
Mar 19, 2024

Conversation

kdestin
Copy link
Member

@kdestin kdestin commented Mar 18, 2024 •
edited
Loading

Description

This pull request addresses ApiView review feedback that pointed out that an experimental model was not exposed publicly.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@kdestin kdestin requested a review from annatisch March 18, 2024 23:36
@luigiw luigiw merged commit 9814f59 into Azure:main Mar 19, 2024
19 checks passed
kdestin added a commit to kdestin/azure-sdk-for-python that referenced this pull request Mar 19, 2024
@kdestin
fix: Expose DataAsset class publicly (Azure#34814)
f535373 
* fix: Expose DataAsset class publicly

* doc: Fix DataAsset docstring

* refactor: Make DataAsset params keyword only

* refactor: Remove kwargs from model

* refactor: Remove unused pylint directive

* docs: Update typing in docstring
kdestin added a commit that referenced this pull request Mar 19, 2024
@kdestin
fix: Expose DataAsset class publicly (#34814) (#34837)
8814519 
* fix: Expose DataAsset class publicly

* doc: Fix DataAsset docstring

* refactor: Make DataAsset params keyword only

* refactor: Remove kwargs from model

* refactor: Remove unused pylint directive

* docs: Update typing in docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch annatisch approved these changes

@luigiw luigiw luigiw approved these changes

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@MilesHolland MilesHolland Awaiting requested review from MilesHolland

@needuv needuv Awaiting requested review from needuv

@ninghu ninghu Awaiting requested review from ninghu

@YusakuNo1 YusakuNo1 Awaiting requested review from YusakuNo1

@hugoaponte hugoaponte Awaiting requested review from hugoaponte

@Man-MSFT Man-MSFT Awaiting requested review from Man-MSFT

Assignees
No one assigned
Labels
Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kdestin @azure-sdk @luigiw @annatisch