Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR network/resource-manager] Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic #3218

Merged
merged 1 commit into from
Aug 30, 2018
Merged

[AutoPR network/resource-manager] Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic #3218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions azure-mgmt-network/azure/mgmt/network/v2018_08_01/models/azure_firewall_ip_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,8 @@ class AzureFirewallIPConfiguration(SubResource):
:param subnet: Reference of the subnet resource. This resource must be
named 'AzureFirewallSubnet'.
:type subnet: ~azure.mgmt.network.v2018_08_01.models.SubResource
:param internal_public_ip_address: Reference of the PublicIP resource.
This field is a mandatory input.
:type internal_public_ip_address:
~azure.mgmt.network.v2018_08_01.models.SubResource
:param public_ip_address: Reference of the PublicIP resource. This field
is populated in the output.
is a mandatory input if subnet is not null.
:type public_ip_address:
~azure.mgmt.network.v2018_08_01.models.SubResource
:param provisioning_state: The provisioning state of the resource.
Expand All @@ -47,7 +43,6 @@ class AzureFirewallIPConfiguration(SubResource):
'id': {'key': 'id', 'type': 'str'},
'private_ip_address': {'key': 'properties.privateIPAddress', 'type': 'str'},
'subnet': {'key': 'properties.subnet', 'type': 'SubResource'},
'internal_public_ip_address': {'key': 'properties.internalPublicIpAddress', 'type': 'SubResource'},
'public_ip_address': {'key': 'properties.publicIPAddress', 'type': 'SubResource'},
'provisioning_state': {'key': 'properties.provisioningState', 'type': 'str'},
'name': {'key': 'name', 'type': 'str'},
Expand All @@ -58,7 +53,6 @@ def __init__(self, **kwargs):
super(AzureFirewallIPConfiguration, self).__init__(**kwargs)
self.private_ip_address = kwargs.get('private_ip_address', None)
self.subnet = kwargs.get('subnet', None)
self.internal_public_ip_address = kwargs.get('internal_public_ip_address', None)
self.public_ip_address = kwargs.get('public_ip_address', None)
self.provisioning_state = kwargs.get('provisioning_state', None)
self.name = kwargs.get('name', None)
Expand Down
10 changes: 2 additions & 8 deletions ...mgmt-network/azure/mgmt/network/v2018_08_01/models/azure_firewall_ip_configuration_py3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,8 @@ class AzureFirewallIPConfiguration(SubResource):
:param subnet: Reference of the subnet resource. This resource must be
named 'AzureFirewallSubnet'.
:type subnet: ~azure.mgmt.network.v2018_08_01.models.SubResource
:param internal_public_ip_address: Reference of the PublicIP resource.
This field is a mandatory input.
:type internal_public_ip_address:
~azure.mgmt.network.v2018_08_01.models.SubResource
:param public_ip_address: Reference of the PublicIP resource. This field
is populated in the output.
is a mandatory input if subnet is not null.
:type public_ip_address:
~azure.mgmt.network.v2018_08_01.models.SubResource
:param provisioning_state: The provisioning state of the resource.
Expand All @@ -47,18 +43,16 @@ class AzureFirewallIPConfiguration(SubResource):
'id': {'key': 'id', 'type': 'str'},
'private_ip_address': {'key': 'properties.privateIPAddress', 'type': 'str'},
'subnet': {'key': 'properties.subnet', 'type': 'SubResource'},
'internal_public_ip_address': {'key': 'properties.internalPublicIpAddress', 'type': 'SubResource'},
'public_ip_address': {'key': 'properties.publicIPAddress', 'type': 'SubResource'},
'provisioning_state': {'key': 'properties.provisioningState', 'type': 'str'},
'name': {'key': 'name', 'type': 'str'},
'etag': {'key': 'etag', 'type': 'str'},
}

def __init__(self, *, id: str=None, private_ip_address: str=None, subnet=None, internal_public_ip_address=None, public_ip_address=None, provisioning_state=None, name: str=None, etag: str=None, **kwargs) -> None:
def __init__(self, *, id: str=None, private_ip_address: str=None, subnet=None, public_ip_address=None, provisioning_state=None, name: str=None, etag: str=None, **kwargs) -> None:
super(AzureFirewallIPConfiguration, self).__init__(id=id, **kwargs)
self.private_ip_address = private_ip_address
self.subnet = subnet
self.internal_public_ip_address = internal_public_ip_address
self.public_ip_address = public_ip_address
self.provisioning_state = provisioning_state
self.name = name
Expand Down