Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR network/resource-manager] Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic #3218

Merged

Conversation

AutorestCI
Copy link
Contributor

Use the correct name for publicIPAddress in AzureFirewall PUT example
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Aug 28, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-network

You can install the package azure-mgmt-network of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3743#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3743#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3743
  • pip install -e ./azure-mgmt-network

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3743
  • pip wheel --no-deps ./azure-mgmt-network

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #3218 into restapi_auto_Network-September-Release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                           @@
##           restapi_auto_Network-September-Release    #3218   +/-   ##
=======================================================================
  Coverage                                   55.17%   55.17%           
=======================================================================
  Files                                        9200     9200           
  Lines                                      185011   185011           
=======================================================================
  Hits                                       102077   102077           
  Misses                                      82934    82934

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f56e6d...832453d. Read the comment docs.

@AutorestCI AutorestCI merged commit 4f1c1db into restapi_auto_Network-September-Release Aug 30, 2018
@AutorestCI AutorestCI deleted the restapi_auto_3743 branch August 30, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants