Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joharrington/Workspace Managed Network #28879

Merged
merged 6 commits into from
Feb 22, 2023

Conversation

joshharrin
Copy link
Member

@joshharrin joshharrin commented Feb 17, 2023

Description

This PR is to add the managed network property to the workspace. This is supported by regenerating the restclient and using the 2022-12-01-preview version and newer. I have made updates to the restclient being used and the corresponding swagger file. I have also added operations on the outbound rules of the managed network property. I have added tests to cover these changes as well.

https://github.com/Azure/azureml_run_specification/pull/962

Azure/azure-rest-api-specs#22588
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@singankit singankit merged commit 16123df into Azure:main Feb 22, 2023
@joshharrin joshharrin deleted the joharrington/ws-managed-network branch May 10, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants