Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate from 2022_12_01_preview API to 2023_02_01_preview API #28863

Merged
merged 19 commits into from
Mar 3, 2023

Conversation

TonyJ1
Copy link
Member

@TonyJ1 TonyJ1 commented Feb 16, 2023

Description

DONE: Revert the following changes used to test against master MFE:

  1. sdk/ml/azure-ai-ml/azure/ai/ml/_ml_client.py base_url="https://master.api.azureml-test.ms/mferp/managementfrontend"
  2. sdk/ml/azure-ai-ml/tests/conftest.py add_uri_string_sanitizer()

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@novaturient95
Copy link
Member

@TonyJ1 automl jobs were migrated to 12/22 API last week. Will they be migrated to Feb API as part of this PR as well?

@TonyJ1
Copy link
Member Author

TonyJ1 commented Mar 2, 2023

@TonyJ1 automl jobs were migrated to 12/22 API last week. Will they be migrated to Feb API as part of this PR as well?

Yes. Please let me know if you find any thing missing for automl.

@TonyJ1 TonyJ1 closed this Mar 2, 2023
@TonyJ1 TonyJ1 reopened this Mar 2, 2023
sdk/ml/azure-ai-ml/tests/conftest.py Outdated Show resolved Hide resolved
sdk/ml/azure-ai-ml/tests/conftest.py Outdated Show resolved Hide resolved
joshharrin
joshharrin previously approved these changes Mar 2, 2023
@joshharrin joshharrin dismissed their stale review March 2, 2023 21:13

looks good from workspace side

sdk/ml/azure-ai-ml/azure/ai/ml/_ml_client.py Outdated Show resolved Hide resolved
@TonyJ1 TonyJ1 merged commit 36da8f0 into Azure:main Mar 3, 2023
@TonyJ1 TonyJ1 deleted the TonyJ1/Use2023-02-01Preview branch March 15, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants