Joharrington/Workspace Managed Network #28464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
joshharrin
force-pushed
the
joharrington/managed-network-private-preview
branch
5 times, most recently
from
1b8abfe to
5621119
Compare
added 14 commits
February 14, 2023 11:00
joshharrin
force-pushed
the
joharrington/managed-network-private-preview
branch
from
58365c4 to
2cd9cf4
Compare
joshharrin
changed the title
* Removes custom exception. Adds missing dictionary methods. Changed KeyVaultOptions to be Keyword only. * Update CHANGELOG.md * Moving load logic out of AzureAppConfigurationProvider * Update CHANGELOG.md * Updating syntax * Fixed import * Fixing Lint issue * Fixed Spaces * Temp removing TokenCredential hint * Adding Async * fixing some async issues * Adding close method * Trying to fix async * Updated Asysnc, Added samples, fixed key vault bug * Adding Async Tests * Added missing async and awaits * Cleaned up extra code. * Fix Async Tests running * Fixing formatting and missing secret_clients map * Updating recordings * Fixing Lint, Updated Change Log * Adding keyVaultOptions validation, removed unused imports in samples * Added some code for minimal Feature Management support to not cause future issues. Also switched to SDK for Content Type. * Moving KeyVaultOptions and SettingSelector into models * Update sdk/appconfiguration/azure-appconfiguration-provider/CHANGELOG.md Co-authored-by: Anna Tisch <[email protected]> * Updating async usage types and removing old imports from samples * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py Co-authored-by: Anna Tisch <[email protected]> * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py Co-authored-by: Anna Tisch <[email protected]> * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py Co-authored-by: Anna Tisch <[email protected]> * Reusing __is_json_content_type * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/aio/_azureappconfigurationproviderasync.py Co-authored-by: Anna Tisch <[email protected]> * Updating to ValueError in non-async too * Fixed load_provider credential type * Fixing Whitespace * Adding cSpell ignore for azconfig * Adding Context Manager methods to sync version * Some typing updates * Adding Host Type tracing * Fix kwarg name * Added async type hints * Fixing test recordings * Update shared_requirements.txt * Pylint cleanup * Update setup.py * Updating min Azure Core dependency * Update shared_requirements.txt * Removing invalid recordings * Using keys method * Updating to 1.4.0 version * Updating to use isinstance --------- Co-authored-by: Anna Tisch <[email protected]>
* apply black to azure-core, azure-core-experimental, azure-core-tracing-opencensus, azure-core-tracing-opentelemetry, azure-mgmt-core * add spellcheck override for core Co-authored-by: Xiang Yan <[email protected]>
Co-authored-by: Konrad Jamrozik <[email protected]>
* when archetype-sdk-tests is called multiple times, the static name of �nalysis breaks the yaml generation due to identical stage names, update stage name to be auto generated
…skips. remove existing exclusion lists from environment_exclusion.py ***NO_CI***
…y SDK owner) (Azure#28856) * code and test * Update CHANGELOG.md * Update _version.py --------- Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <[email protected]>
Signed-off-by: Brynn Yin <[email protected]>
Increment package version after release of azure-appconfiguration-provider
Signed-off-by: Paul Van Eck <[email protected]>
* - improve $commandOutput processing - capitalization fixups + some naming refactoring - update ToolVersion to 1.0.0-dev.20230213.7 - fix param: --codeowners-file-path -> --codeowners-file-path-or-url; minor fixes - update Azure.Sdk.Tools.RetrieveCodeOwners package ver to 20230213.2 - document params + add TargetPath * update ToolVersion to 1.0.0-dev.20230214.3 * Add diag output + tests * replace sima-zhu with konrad-jamrozik --------- Co-authored-by: Konrad Jamrozik <[email protected]>
Signed-off-by: Paul Van Eck <[email protected]>
…//github.com/joshharrin/azure-sdk-for-python into joharrington/managed-network-private-preview
|
messed up git commit history :( will reopen PR from new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add the managed network property to the workspace. This is supported by regenerating the restclient and using the 2022-12-01-preview version and newer. I have made updates to the restclient being used and the corresponding swagger file. I have also added operations on the outbound rules of the managed network property. I have added tests to cover these changes as well.
https://github.com/Azure/azureml_run_specification/pull/904
Azure/azure-rest-api-specs#22588
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines