Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Pipelines] fix: avoid raising OSError for invalid paths in LocalPathField deserialization #28804

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

elliotzh
Copy link
Contributor

@elliotzh elliotzh commented Feb 14, 2023

Description

For invalid path value like "azureml:/subscription/xxxxx", raise ValidationError instead of OSError, as OSError will directly break UnionField deserialization.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@elliotzh elliotzh force-pushed the zhangxingzhi/fix-path-field-deserialization branch 2 times, most recently from bbdd0f2 to 6108ce7 Compare February 14, 2023 10:23
@elliotzh elliotzh changed the title [ML][Pipelines] fix: avoid OSError in LocalPathField deserialization [ML][Pipelines] fix: avoid raising OSError for invalid paths in LocalPathField deserialization Feb 14, 2023
@wangchao1230 wangchao1230 enabled auto-merge (squash) February 16, 2023 07:37
@elliotzh elliotzh force-pushed the zhangxingzhi/fix-path-field-deserialization branch from 6108ce7 to 2c15f28 Compare February 16, 2023 08:18
@wangchao1230 wangchao1230 merged commit ac12f80 into main Feb 16, 2023
@wangchao1230 wangchao1230 deleted the zhangxingzhi/fix-path-field-deserialization branch February 16, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants