Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Proxy] Add method to reset setting customizations #24952

Merged
merged 2 commits into from
Jun 23, 2022
Merged

[Test Proxy] Add method to reset setting customizations #24952

merged 2 commits into from
Jun 23, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 22, 2022

Description

Per the instructions about restoring default settings, this adds a set_default_settings method that can be used to reset test proxy setting customizations at either the test case or session level.

@scbedd for notifs

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • Tested with azure-data-tables for both test case- and session-level setting restoration.

@mccoyp mccoyp added EngSys This issue is impacting the engineering system. test-enhancement labels Jun 22, 2022
@mccoyp mccoyp requested a review from scbedd June 22, 2022 23:58
@mccoyp mccoyp merged commit 28ab809 into Azure:main Jun 23, 2022
@mccoyp mccoyp deleted the proxy-reset branch June 23, 2022 22:21
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 27, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
d23dd87 
…into merge_patch

* 'main' of https://github.com/Azure/azure-sdk-for-python: (155 commits)
  {machine learning} || Fix a bug in the code (Azure#24922)
  [CLU] support for AAD + docs (Azure#24960)
  Update dpg version (Azure#24986)
  [Botservice]fix model (Azure#24971)
  [perf] Add pipeline template and storage pipelines (Azure#24894)
  [Storage] Remove client-side encryption code from shared (Azure#24931)
  [EventHubs&ServiceBus] update docker images to internal (Azure#24966)
  Sync eng/common directory with azure-sdk-tools for PR 3481 (Azure#24964)
  [Dpg] update to use global autorest version (Azure#24970)
  [CLU] release updates + fix tests (Azure#24963)
  [Test Proxy] Add method to reset setting customizations (Azure#24952)
  [Storage] Add proxy-supporting test classes (Azure#24937)
  [Confidential Ledger] Enable live testing (Azure#24912)
  fix type of _SansIOHTTPPolicyRunner (Azure#24932)
  Adding SIP routing functionality to PhoneNumbers SDK (Azure#22805)
  [DPG] update quick-start-tool (Azure#24942)
  [formrecognizer] Enable copy model tests (Azure#24917)
  [CLU] remove maxpagesize (Azure#24949)
  Use westus3 for translation live tests (Azure#24947)
  [Storage] Make lease duration tests less flakey (Azure#24930)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system. test-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccoyp @scbedd