Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Add base test classes that support the test proxy #24937

Merged
merged 1 commit into from
Jun 23, 2022
Merged

[Storage] Add base test classes that support the test proxy #24937

merged 1 commit into from
Jun 23, 2022

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 22, 2022

Description

This adds two new test classes to devtools_testutils -- AsyncStorageRecordedTestCase and StorageRecordedTestCase -- that support the test proxy system. Migrated tests should inherit from these classes instead of AsyncStorageTestCase and StorageTestCase.

These classes currently use the setup_class method to set a self.sas_token attribute, to emulate the setup done in test_blob_client(_async).py today. However, this should be removed (if possible) once tests migrate to using AzureRecordedTestCase's generate_sas method.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

@mccoyp mccoyp added Storage Storage Service (Queues, Blobs, Files) EngSys This issue is impacting the engineering system. labels Jun 22, 2022
@mccoyp mccoyp merged commit d653189 into Azure:main Jun 23, 2022
@mccoyp mccoyp deleted the proxy-storage-class branch June 23, 2022 21:54
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 27, 2022
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
d23dd87 
…into merge_patch

* 'main' of https://github.com/Azure/azure-sdk-for-python: (155 commits)
  {machine learning} || Fix a bug in the code (Azure#24922)
  [CLU] support for AAD + docs (Azure#24960)
  Update dpg version (Azure#24986)
  [Botservice]fix model (Azure#24971)
  [perf] Add pipeline template and storage pipelines (Azure#24894)
  [Storage] Remove client-side encryption code from shared (Azure#24931)
  [EventHubs&ServiceBus] update docker images to internal (Azure#24966)
  Sync eng/common directory with azure-sdk-tools for PR 3481 (Azure#24964)
  [Dpg] update to use global autorest version (Azure#24970)
  [CLU] release updates + fix tests (Azure#24963)
  [Test Proxy] Add method to reset setting customizations (Azure#24952)
  [Storage] Add proxy-supporting test classes (Azure#24937)
  [Confidential Ledger] Enable live testing (Azure#24912)
  fix type of _SansIOHTTPPolicyRunner (Azure#24932)
  Adding SIP routing functionality to PhoneNumbers SDK (Azure#22805)
  [DPG] update quick-start-tool (Azure#24942)
  [formrecognizer] Enable copy model tests (Azure#24917)
  [CLU] remove maxpagesize (Azure#24949)
  Use westus3 for translation live tests (Azure#24947)
  [Storage] Make lease duration tests less flakey (Azure#24930)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalauzon-msft jalauzon-msft jalauzon-msft approved these changes

@scbedd scbedd scbedd approved these changes

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft

Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mccoyp @scbedd @jalauzon-msft