Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Begin migration to test proxy #24570

Closed
wants to merge 6 commits into from
Closed

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented May 24, 2022

Description

This PR is meant to get the process kickstarted to migrate data-plane Storage packages to the test proxy. This introduces a new Storage test class, StorageRecordedTestCase, that inherits from the AzureRecordedTestCase that's used with the test proxy. Eventually, this new class can be renamed and completely replace StorageTestCase.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. test-enhancement labels May 24, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@mccoyp mccoyp force-pushed the storage-proxy branch 2 times, most recently from 0b826ac to 8b0b0f6 Compare May 26, 2022 18:27
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Hi @mccoyp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@mccoyp mccoyp closed this Sep 2, 2022
@mccoyp mccoyp deleted the storage-proxy branch September 2, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. no-recent-activity There has been no recent activity on this issue. Storage Storage Service (Queues, Blobs, Files) test-enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants