Communication Administration: Add on-demand resource creation for live-tests #14366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
October 8, 2020 10:10
turalf
requested review from
ankitarorabit,
RezaJooyandeh and
a team
as code owners
|
/azp run python - communication - ci |
|
No pipelines are associated with this pull request. |
| x-ms-return-client-request-id: | ||
| - 'true' | ||
| method: POST | ||
| uri: https://communication27b5151c.communication.azure.com/identities?api-version=2020-07-20-preview2 |
There was a problem hiding this comment.
Dont you need to sanitize/redact these resource names?
There was a problem hiding this comment.
These resource are in only available in the context of test method. So no need I guess since It gets removed after the test
ankitarorabit
previously approved these changes
Oct 9, 2020
|
/azp run communication |
|
No pipelines are associated with this pull request. |
turalf
dismissed stale reviews from ankitarorabit and RezaJooyandeh
via
1956579
|
No pipelines are associated with this pull request. |
RezaJooyandeh
approved these changes
Oct 13, 2020
xiangyan99
added a commit
that referenced
this pull request
Oct 14, 2020
* [metricsadvisor] live tests setup (#14396) * add live test yml for metrics advisor * some fixes * hardcode test ids and rerecord a few tests * add ids back as env variables * [formrecognizer] initial business cards (#14026) * Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow) * Communication Administration: Add on-demand resource creation for live-tests (#14366) * Add communication service preparer * Refactor dynamic resource creation testing code * Remove setup method of base test class * Change fake conn str to valid format * Remove unused import * Remove main test file * Reduce RG expiry durtion * Async test code change with resource preparer * Add chaching for resource-preparer * Move helper into shared * Move preparer into shared * Uncomment test code * Remove CommunicationResourceGroupPreparer use common instead * Add base testcase for sync pnm * move phone_number_helper to phone_number folder * Add base pnm async testcase * Add __init__ for test folders * Fix identity tests to refer to shared test folder * Refactor base async phonenumber test class * Make decorator consisitent across all async tests utm * Replace fake resource value * Fix type in test file names * Remove commented cache setting code * Add livetest recording files * Refresh recording files * Update recording files * Reorganize the test folder structure * Add mgmt pacakge to the dev reqs Co-authored-by: tural farhadov <[email protected]> * [ServiceBus] Small stress test and sample touchups (#14304) * Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate) * Adjust stress test that was using push receive instead of pull. * Add async version of non-session to session send failure test, make both cached to improve perf. * Codegen for Azure Monitor (#14057) * Codegen fro Azure Monitor * codeowner * commit 2 * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * doc setings * Update eng/.docsettings.yml * Update eng/.docsettings.yml * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * Update eng/.docsettings.yml * version * oops * comments * Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt Co-authored-by: Hector Hernandez <[email protected]> Co-authored-by: Hector Hernandez <[email protected]> * [Storage][FileShare]Regenerate for delete leased snapshot (#14469) * add repr to models (#14475) * remove validations (#14476) * Ma remove readonly assignments (#14478) * Ensure azure-identity readme has exactly one H1 (#14480) The docs publishing system disallows multiple H1 headings in a document. * Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482) * Add pipeline configuration for cleaning up upstream branches * Fix powershell naming * Switch to use github API * Use github API to delete branches Co-authored-by: Chidozie Ononiwu <[email protected]> * enable live tests (#14467) * Removed asynctestcase.py (#14444) * testcase.py now uses AzureTestCase (#14443) Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: tural farhadov <[email protected]> Co-authored-by: KieranBrantnerMagee <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Hector Hernandez <[email protected]> Co-authored-by: Xiaoxi Fu <[email protected]> Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Bradley D'Amato <[email protected]>
xiangyan99
added a commit
that referenced
this pull request
Nov 7, 2020
* customize httpadapter to honor kwargs in send method * update * update * update * update * update * update * update * FI from master (#14501) * [metricsadvisor] live tests setup (#14396) * add live test yml for metrics advisor * some fixes * hardcode test ids and rerecord a few tests * add ids back as env variables * [formrecognizer] initial business cards (#14026) * Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow) * Communication Administration: Add on-demand resource creation for live-tests (#14366) * Add communication service preparer * Refactor dynamic resource creation testing code * Remove setup method of base test class * Change fake conn str to valid format * Remove unused import * Remove main test file * Reduce RG expiry durtion * Async test code change with resource preparer * Add chaching for resource-preparer * Move helper into shared * Move preparer into shared * Uncomment test code * Remove CommunicationResourceGroupPreparer use common instead * Add base testcase for sync pnm * move phone_number_helper to phone_number folder * Add base pnm async testcase * Add __init__ for test folders * Fix identity tests to refer to shared test folder * Refactor base async phonenumber test class * Make decorator consisitent across all async tests utm * Replace fake resource value * Fix type in test file names * Remove commented cache setting code * Add livetest recording files * Refresh recording files * Update recording files * Reorganize the test folder structure * Add mgmt pacakge to the dev reqs Co-authored-by: tural farhadov <[email protected]> * [ServiceBus] Small stress test and sample touchups (#14304) * Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate) * Adjust stress test that was using push receive instead of pull. * Add async version of non-session to session send failure test, make both cached to improve perf. * Codegen for Azure Monitor (#14057) * Codegen fro Azure Monitor * codeowner * commit 2 * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * doc setings * Update eng/.docsettings.yml * Update eng/.docsettings.yml * Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md * Update eng/.docsettings.yml * version * oops * comments * Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt Co-authored-by: Hector Hernandez <[email protected]> Co-authored-by: Hector Hernandez <[email protected]> * [Storage][FileShare]Regenerate for delete leased snapshot (#14469) * add repr to models (#14475) * remove validations (#14476) * Ma remove readonly assignments (#14478) * Ensure azure-identity readme has exactly one H1 (#14480) The docs publishing system disallows multiple H1 headings in a document. * Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482) * Add pipeline configuration for cleaning up upstream branches * Fix powershell naming * Switch to use github API * Use github API to delete branches Co-authored-by: Chidozie Ononiwu <[email protected]> * enable live tests (#14467) * Removed asynctestcase.py (#14444) * testcase.py now uses AzureTestCase (#14443) Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: tural farhadov <[email protected]> Co-authored-by: KieranBrantnerMagee <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Hector Hernandez <[email protected]> Co-authored-by: Xiaoxi Fu <[email protected]> Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Bradley D'Amato <[email protected]> * update * update * update * update * update * update * update * update Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: turalf <[email protected]> Co-authored-by: tural farhadov <[email protected]> Co-authored-by: KieranBrantnerMagee <[email protected]> Co-authored-by: Rakshith Bhyravabhotla <[email protected]> Co-authored-by: Hector Hernandez <[email protected]> Co-authored-by: Xiaoxi Fu <[email protected]> Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: Chidozie Ononiwu <[email protected]> Co-authored-by: Bradley D'Amato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds on demand resource creation for identity operations. Phone number live tests still work on pre-created resource.
Pending: Resource caching. There is an option to cache some of the resources so not each test would create a resource. This will be added in upcoming PR