Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testcase.py now uses AzureTestCase #14443

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

bradleydamato
Copy link
Contributor

Hi @seankane-msft ; it looks like a change only need to be made in testcase.py as asynctestcase.py imports TableTestCase from the former.

I've run the tox tests and here are the results:
image

@ghost ghost added Tables customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Oct 12, 2020
@ghost
Copy link

ghost commented Oct 12, 2020

Thank you for your contribution bradleydamato! We will review the pull request and get back to you soon.

@seankane-msft
Copy link
Member

Thanks @bradleydamato! I will double check this by pulling down your branch and running these against our live resources just to double check. I'll let you know what the results are

@seankane-msft seankane-msft self-assigned this Oct 13, 2020
@seankane-msft
Copy link
Member

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the help @bradleydamato

@bradleydamato
Copy link
Contributor Author

Hey @seankane-msft thanks for the approval! Just an FYI that I am not able to merge to master, but also no rush on my end! CC@annatisch

@seankane-msft
Copy link
Member

Sorry about that @bradleydamato, merging it now! Thanks for the contribution!

@seankane-msft seankane-msft merged commit 6c59c00 into Azure:master Oct 14, 2020
xiangyan99 added a commit that referenced this pull request Oct 14, 2020
* [metricsadvisor] live tests setup (#14396)

* add live test yml for metrics advisor

* some fixes

* hardcode test ids and rerecord a few tests

* add ids back as env variables

* [formrecognizer] initial business cards (#14026)

* Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445)

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081
 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)

* Communication Administration: Add on-demand resource creation for live-tests  (#14366)

* Add communication service preparer

* Refactor dynamic resource creation testing code

* Remove setup method of base test class

* Change fake conn str to valid format

* Remove unused import

* Remove main test file

* Reduce RG expiry durtion

* Async test code change with resource preparer

* Add chaching for resource-preparer

* Move helper into shared

* Move preparer into shared

* Uncomment test code

* Remove CommunicationResourceGroupPreparer use common instead

* Add base testcase for sync pnm

* move phone_number_helper to phone_number folder

* Add base pnm async testcase

* Add __init__ for test folders

* Fix identity tests to refer to shared test folder

* Refactor base async phonenumber test class

* Make decorator consisitent across all async tests utm

* Replace fake resource value

* Fix type in test file names

* Remove commented cache setting code

* Add livetest recording files

* Refresh recording files

* Update recording files

* Reorganize the test folder structure

* Add mgmt pacakge to the dev reqs

Co-authored-by: tural farhadov <[email protected]>

* [ServiceBus] Small stress test and sample touchups (#14304)

* Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate)
* Adjust stress test that was using push receive instead of pull.
* Add async version of non-session to session send failure test, make both cached to improve perf.

* Codegen for Azure Monitor (#14057)

* Codegen fro Azure Monitor

* codeowner

* commit 2

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md

* doc setings

* Update eng/.docsettings.yml

* Update eng/.docsettings.yml

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md

* Update eng/.docsettings.yml

* version

* oops

* comments

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt

Co-authored-by: Hector Hernandez <[email protected]>

Co-authored-by: Hector Hernandez <[email protected]>

* [Storage][FileShare]Regenerate for delete leased snapshot (#14469)

* add repr to models (#14475)

* remove validations (#14476)

* Ma remove readonly assignments (#14478)

* Ensure azure-identity readme has exactly one H1 (#14480)

The docs publishing system disallows multiple H1 headings in a document.

* Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482)

* Add pipeline configuration for cleaning up upstream branches

* Fix powershell naming

* Switch to use github API

* Use github API to delete branches

Co-authored-by: Chidozie Ononiwu <[email protected]>

* enable live tests (#14467)

* Removed asynctestcase.py (#14444)

* testcase.py now uses AzureTestCase (#14443)

Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: turalf <[email protected]>
Co-authored-by: tural farhadov <[email protected]>
Co-authored-by: KieranBrantnerMagee <[email protected]>
Co-authored-by: Rakshith Bhyravabhotla <[email protected]>
Co-authored-by: Hector Hernandez <[email protected]>
Co-authored-by: Xiaoxi Fu <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Bradley D'Amato <[email protected]>
xiangyan99 added a commit that referenced this pull request Nov 7, 2020
* customize httpadapter to honor kwargs in send method

* update

* update

* update

* update

* update

* update

* update

* FI from master (#14501)

* [metricsadvisor] live tests setup (#14396)

* add live test yml for metrics advisor

* some fixes

* hardcode test ids and rerecord a few tests

* add ids back as env variables

* [formrecognizer] initial business cards (#14026)

* Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445)

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081
 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)

* Communication Administration: Add on-demand resource creation for live-tests  (#14366)

* Add communication service preparer

* Refactor dynamic resource creation testing code

* Remove setup method of base test class

* Change fake conn str to valid format

* Remove unused import

* Remove main test file

* Reduce RG expiry durtion

* Async test code change with resource preparer

* Add chaching for resource-preparer

* Move helper into shared

* Move preparer into shared

* Uncomment test code

* Remove CommunicationResourceGroupPreparer use common instead

* Add base testcase for sync pnm

* move phone_number_helper to phone_number folder

* Add base pnm async testcase

* Add __init__ for test folders

* Fix identity tests to refer to shared test folder

* Refactor base async phonenumber test class

* Make decorator consisitent across all async tests utm

* Replace fake resource value

* Fix type in test file names

* Remove commented cache setting code

* Add livetest recording files

* Refresh recording files

* Update recording files

* Reorganize the test folder structure

* Add mgmt pacakge to the dev reqs

Co-authored-by: tural farhadov <[email protected]>

* [ServiceBus] Small stress test and sample touchups (#14304)

* Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate)
* Adjust stress test that was using push receive instead of pull.
* Add async version of non-session to session send failure test, make both cached to improve perf.

* Codegen for Azure Monitor (#14057)

* Codegen fro Azure Monitor

* codeowner

* commit 2

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md

* doc setings

* Update eng/.docsettings.yml

* Update eng/.docsettings.yml

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md

* Update eng/.docsettings.yml

* version

* oops

* comments

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt

Co-authored-by: Hector Hernandez <[email protected]>

Co-authored-by: Hector Hernandez <[email protected]>

* [Storage][FileShare]Regenerate for delete leased snapshot (#14469)

* add repr to models (#14475)

* remove validations (#14476)

* Ma remove readonly assignments (#14478)

* Ensure azure-identity readme has exactly one H1 (#14480)

The docs publishing system disallows multiple H1 headings in a document.

* Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482)

* Add pipeline configuration for cleaning up upstream branches

* Fix powershell naming

* Switch to use github API

* Use github API to delete branches

Co-authored-by: Chidozie Ononiwu <[email protected]>

* enable live tests (#14467)

* Removed asynctestcase.py (#14444)

* testcase.py now uses AzureTestCase (#14443)

Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: turalf <[email protected]>
Co-authored-by: tural farhadov <[email protected]>
Co-authored-by: KieranBrantnerMagee <[email protected]>
Co-authored-by: Rakshith Bhyravabhotla <[email protected]>
Co-authored-by: Hector Hernandez <[email protected]>
Co-authored-by: Xiaoxi Fu <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Bradley D'Amato <[email protected]>

* update

* update

* update

* update

* update

* update

* update

* update

Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: turalf <[email protected]>
Co-authored-by: tural farhadov <[email protected]>
Co-authored-by: KieranBrantnerMagee <[email protected]>
Co-authored-by: Rakshith Bhyravabhotla <[email protected]>
Co-authored-by: Hector Hernandez <[email protected]>
Co-authored-by: Xiaoxi Fu <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Chidozie Ononiwu <[email protected]>
Co-authored-by: Bradley D'Amato <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 24, 2021
add configurations for 5 ring 0 RPs (Azure#14443)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 25, 2021
add configurations for 5 ring 0 RPs (Azure#14443)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 25, 2021
add configurations for 5 ring 0 RPs (Azure#14443)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 25, 2021
add configurations for 5 ring 0 RPs (Azure#14443)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 25, 2021
add configurations for 5 ring 0 RPs (Azure#14443)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 25, 2021
add configurations for 5 ring 0 RPs (Azure#14443)
msyyc pushed a commit that referenced this pull request May 26, 2021
* CodeGen from PR 14443 in Azure/azure-rest-api-specs
add configurations for 5 ring 0 RPs (#14443)

* version,CHANGELOG

* test

* test config

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed <[email protected]>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jun 1, 2021
* CodeGen from PR 14443 in Azure/azure-rest-api-specs
add configurations for 5 ring 0 RPs (Azure#14443)

* version,CHANGELOG

* test

* test config

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants