Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservations RP 2018-06-01 Preview: Add RedHat in reserved resource t… #5001

Closed
wants to merge 4 commits into from

Conversation

luluRagdoll
Copy link

@luluRagdoll luluRagdoll commented Nov 5, 2018

…ype enum

Description

LINK:
Azure/azure-rest-api-specs#4370

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Nov 7, 2018

Please fix build failures

@dsgouda
Copy link
Contributor

dsgouda commented Nov 12, 2018

@azuresdkci retest this please

@@ -36,5 +36,5 @@ internal static partial class SdkInfo
public static readonly String CodeGenerationErrors = "";
public static readonly String GithubRepoName = "azure-rest-api-specs";
// END: Code Generation Metadata Section
}
Copy link
Contributor

@dsgouda dsgouda Nov 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be edited manually. Please regenerate the code.
If there are issues with the generated file, please do the following

  1. Run
git clean -xdff
msbuild build.proj
  1. Regenerate the code

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda Hi,
I remembered this is a bug in the auto-generating script? Last time I had the same issue and had to fix this manually. :)

Last time my PR :
#4725

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luluRagdoll This has been fixed in our latest build tools. please follow the steps I mentioned above and regenerate the code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luluRagdoll Please follow the steps described above and regenerate the code

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version number and PackageReleaseNotes in csproj

@dsgouda
Copy link
Contributor

dsgouda commented Nov 30, 2018

@luluRagdoll PR has been inactive since more than 2 weeks. Please open a new one once you've addressed the comments

@dsgouda dsgouda closed this Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants