Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reservations RP 2018-06-01 Preview: Add new reserved resource enum type RedHat #4370

Merged
merged 5 commits into from
Nov 2, 2018

Conversation

luluRagdoll
Copy link
Contributor

@luluRagdoll luluRagdoll commented Oct 31, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@luluRagdoll luluRagdoll changed the title Reservations RP 2018-06-01 Preview: Add new reserved resource type RedHat Reservations RP 2018-06-01 Preview: Add new reserved resource enum type RedHat Oct 31, 2018
@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3726

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#388

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3218

@AutorestCI
Copy link

AutorestCI commented Oct 31, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4010

@luluRagdoll
Copy link
Contributor Author

This is similar to what we have done before. We are accepting one more enum type in the reserved resource type.
Previous PR link: #3690
I have validated the Yaml and update the python version.
Please feel free to let me know if there is anything else.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@luluRagdoll
Copy link
Contributor Author

luluRagdoll commented Oct 31, 2018

@sergey-shandar Looks like I am getting this error: But that is under a preview folder. Could you help take a look pls? Thx

Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
 Including configuration file 'file:///tmp/tmpai3z3hi8/rest/specification/reservations/resource-manager/readme.go.md'
 Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.119->2.1.119)
 Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-06"} .
 Including configuration file 'file:///tmp/tmpai3z3hi8/rest/specification/reservations/resource-manager/readme.go.md'
FATAL: Sy**stem.InvalidOperationException: codegen for preview swagger Microsoft.Capacity/preview/2018-06-01/reservations.json must be under a preview subdirectory**

@sergey-shandar
Copy link
Contributor

@luluRagdoll I've restarted the Go SDK build.
@juhee0202 could you review the PR?

@luluRagdoll
Copy link
Contributor Author

@sergey-shandar Looks like the Go is still failing. The error msg indicates I am not putting the preview under a preview subdirectory...But it is under preview director. Just wondering is that a valid check in the automation script?

@sergey-shandar
Copy link
Contributor

@luluRagdoll is this API still in preview?

@sergey-shandar
Copy link
Contributor

Thank you @jhendrixMSFT.

@veronicagg
Copy link
Contributor

license/cla not running properly right now, but ran before and reported green, so merging PR.

@veronicagg veronicagg merged commit 4e6184d into Azure:master Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants