Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cognitive Services] Update endpoint template for Content Moderator SDK. #4653

Merged
merged 2 commits into from Aug 22, 2018
Merged

[Cognitive Services] Update endpoint template for Content Moderator SDK. #4653

merged 2 commits into from Aug 22, 2018

Conversation

yangyuan
Copy link
Member

Azure/azure-rest-api-specs#3505

  1. Update auto generated code.
  2. Update tests accordingly.
  3. Bump version/Add AssemblyInfo/Update release notes.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Aug 10, 2018
View reviewed changes
.../ContentModerator/ContentModerator/Microsoft.Azure.CognitiveServices.ContentModerator.csproj
@@ -5,7 +5,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.ContentModerator</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services Content Moderator APIs.</Description>
<Version>0.12.1-preview</Version>
<Version>0.13.0-preview</Version>
<AssemblyName>Microsoft.Azure.CognitiveServices.ContentModerator</AssemblyName>
<PackageTags>ContentModerator;Content Moderator;</PackageTags>
<PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PackageReleaseNotes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

...nitiveServices/dataPlane/Vision/ContentModerator/ContentModerator/Properties/AssemblyInfo.cs Outdated
[assembly: AssemblyTitle("Microsoft Cognitive Services Content Moderator SDK")]
[assembly: AssemblyDescription("Provides access to the Microsoft Cognitive Services Content Moderator APIs.")]

[assembly: AssemblyVersion("0.13.0.0")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssemblyVersion must be set to the first nuget package version that was published.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the first was 0.9.0, so changed AssemblyVersion to 0.9.0.0

@dsgouda
Copy link
Contributor

dsgouda commented Aug 10, 2018

Please fix the build errors too

dsgouda
dsgouda approved these changes Aug 10, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Aug 10, 2018

Will merge once CIs pass

@yangyuan
Copy link
Member Author

@dsgouda I guess the building error haven't been fixed yet. I'm looking into it.
It's weird because I didn't change test proj config or test logic

@yangyuan yangyuan mentioned this pull request Aug 14, 2018
Closed
9 tasks
@shahabhijeet
Copy link
Member

@yangyuan you have a test failure.
Open this file in VS and you will see the test failure.
https://azuresdkci.westus2.cloudapp.azure.com/job/CI-NetSDK_U/226/artifact/TestResults/net452/

@yangyuan
Copy link
Member Author

Thanks for the hint, it seems I might need to do some changes in the API specifications to fix it.

@yangyuan
Copy link
Member Author

yangyuan commented Aug 20, 2018 •
edited
Loading

Sent a PR for swagger which should be helpful in fixing the issue,
Azure/azure-rest-api-specs#3681

@yangyuan
Copy link
Member Author

@dsgouda looks like the issue get fixed.

@dsgouda dsgouda merged commit 647099f into Azure:psSdkJson6 Aug 22, 2018
@swiftarrow11
Copy link

Looks good. @sanjeev3, we should plan to update our SDK samples to use this version. Note: Our sdk will now use the Endpoint parameter instead of baseurl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangyuan @dsgouda @shahabhijeet @swiftarrow11