[Cognitive Services] Update endpoint URL template for Content Moderator. #3505

yangyuan · 2018-07-25T21:49:36Z

Detail background and explainations in here: #3489 Cognitive Services URL template (endpoint)

Please hold for swiftarrow11 or sanjeev3's review as well as my confirmation.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

yangyuan · 2018-07-25T21:49:57Z

specification/cognitiveservices/data-plane/ContentModerator/readme.nodejs.md

@@ -8,7 +8,6 @@ nodejs:
  package-name: azure-cognitiveservices-contentmoderator
  package-version: 1.0.0-preview
  output-folder: $(node-sdks-folder)/lib/services/contentModerator
-  override-client-name: ContentModeratorAPIClient


Remove this to keep consistency

yangyuan · 2018-07-25T21:50:20Z

specification/cognitiveservices/data-plane/ContentModerator/stable/v1.0/ContentModerator.json

@@ -3,7 +3,7 @@
  "info": {
    "title": "Content Moderator Client",
    "version": "1.0",
-    "description": "You use the API to scan your content as it is generated. Content Moderator then processes your content and sends the results along with relevant information either back to your systems or to the built-in review tool. You can use this information to take decisions e.g. take it down, send to human judge, etc.\r\n\r\nWhen using the API, images need to have a minimum of 128 pixels and a maximum file size of 4MB. \r\nText can be at most 1024 characters long. \r\nIf the content passed to the text API or the image API exceeds the size limits, the API will return an error code that informs about the issue.\r\n\r\nThis API is currently available in:\r\n\r\n* West US - westus.api.cognitive.microsoft.com\r\n* East US 2 - eastus2.api.cognitive.microsoft.com\r\n* West Central US - westcentralus.api.cognitive.microsoft.com\r\n* West Europe - westeurope.api.cognitive.microsoft.com\r\n* Southeast Asia - southeastasia.api.cognitive.microsoft.com ."


Remove the outdated region list.

AutorestCI · 2018-07-25T21:51:34Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2315

AutorestCI · 2018-07-25T21:53:03Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2438

AutorestCI · 2018-07-25T21:53:13Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1963

AutorestCI · 2018-07-25T21:54:26Z

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1558

AutorestCI · 2018-07-25T22:04:47Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#3238

jhendrixMSFT · 2018-08-01T22:58:21Z

@yangyuan are we still waiting for other reviewers?

azuresdkci · 2018-08-01T22:58:23Z

Can one of the admins verify this patch?

yangyuan · 2018-08-02T00:12:34Z

Hi @jhendrixMSFT. I've updated some SDKs, but heard some negative feedback (also found a small issue in auto-generated documents).
So I decide to hold this PR for a few days and collect feedbacks in case of back/forth changes.

sanjeev3 · 2018-08-07T06:44:14Z

@yangyuan @jhendrixMSFT, I am good with these. @swiftarrow11, how about you?

jhendrixMSFT

There are some model validation failures that need to be addressed, please see the travis log.

yangyuan · 2018-08-08T23:42:11Z

hi @jhendrixMSFT, I've fixed the model validation error.

It shows that Linter Diff complaints some operations missing x-ms-examples.
How about we create an issue and deal with it later? two reasons I recommend that.

Its some legacy issues not related to this change.
The examples should be provided by Content Moderator team.

jhendrixMSFT · 2018-08-08T23:53:53Z

@bsiegel I understand you're working on this new linter diff in CI? I don't think it should be failing for this PR as it doesn't add any new operations.

jhendrixMSFT · 2018-08-09T21:44:06Z

@veronicagg do you know about this new linter behavior?

veronicagg · 2018-08-09T21:56:00Z

@jhendrixMSFT I asked @bsiegel about this in the morning. @bsiegel I think this is another case for the issue you fixed earlier today, in which case this branch would need to be rebased to pick up Brandon's fix. @bsiegel could you check other PRs that may be opened and got affected by it?

yangyuan · 2018-08-10T00:31:27Z

@jhendrixMSFT I have rebase the branch and now all passes. :)

jhendrixMSFT

There are some model validation failures that need to be addressed, please see the travis log.

yangyuan requested a review from swiftarrow11 July 25, 2018 21:49

yangyuan commented Jul 25, 2018

View reviewed changes

azuresdkci assigned jhendrixMSFT Jul 25, 2018

azuresdkci requested a review from jhendrixMSFT July 25, 2018 21:50

AutorestCI mentioned this pull request Jul 25, 2018

[AutoPR cognitiveservices/data-plane/ContentModerator] [Cognitive Services] Update endpoint URL template for Content Moderator. Azure/azure-sdk-for-java#2268

Merged

AutorestCI mentioned this pull request Jul 25, 2018

[AutoPR cognitiveservices/data-plane/ContentModerator] [Cognitive Services] Update endpoint URL template for Content Moderator. Azure/azure-sdk-for-ruby#1517

Merged

AutorestCI mentioned this pull request Jul 25, 2018

[AutoPR cognitiveservices/data-plane/ContentModerator] [Cognitive Services] Update endpoint URL template for Content Moderator. Azure/azure-sdk-for-node#3238

Closed

yangyuan mentioned this pull request Jul 25, 2018

Cognitive Services URL template (endpoint) #3489

Closed

yangyuan requested a review from sanjeev3 July 26, 2018 00:46

yangyuan added In-Review DoNotMerge <valid label in PR review process> use to hold merge after approval and removed In-Review labels Jul 26, 2018

yangyuan mentioned this pull request Aug 2, 2018

[Cognitive Services] Update endpoint URL template for LUIS. #3492

Merged

10 tasks

jhendrixMSFT requested changes Aug 7, 2018

View reviewed changes

yangyuan removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 7, 2018

yangyuan added 2 commits August 9, 2018 15:16

[Cognitive Services] Update endpoint URL template for Content Moderator.

f17ab34

Fix old errors.

541e738

jhendrixMSFT approved these changes Aug 10, 2018

View reviewed changes

jhendrixMSFT merged commit e770705 into Azure:master Aug 10, 2018

yangyuan mentioned this pull request Aug 10, 2018

[Cognitive Services] Update endpoint template for Content Moderator SDK. Azure/azure-sdk-for-net#4653

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cognitive Services] Update endpoint URL template for Content Moderator. #3505

[Cognitive Services] Update endpoint URL template for Content Moderator. #3505

yangyuan commented Jul 25, 2018 •

edited

Loading

yangyuan Jul 25, 2018

yangyuan Jul 25, 2018

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

jhendrixMSFT commented Aug 1, 2018

azuresdkci commented Aug 1, 2018

yangyuan commented Aug 2, 2018 •

edited

Loading

sanjeev3 commented Aug 7, 2018

jhendrixMSFT left a comment

yangyuan commented Aug 8, 2018

jhendrixMSFT commented Aug 8, 2018

jhendrixMSFT commented Aug 9, 2018

veronicagg commented Aug 9, 2018

yangyuan commented Aug 10, 2018

jhendrixMSFT left a comment

[Cognitive Services] Update endpoint URL template for Content Moderator. #3505

[Cognitive Services] Update endpoint URL template for Content Moderator. #3505

Conversation

yangyuan commented Jul 25, 2018 • edited Loading

PR information

Quality of Swagger

yangyuan Jul 25, 2018

Choose a reason for hiding this comment

yangyuan Jul 25, 2018

Choose a reason for hiding this comment

AutorestCI commented Jul 25, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jul 25, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 25, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 25, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jul 25, 2018 • edited Loading

Automation for azure-sdk-for-node

jhendrixMSFT commented Aug 1, 2018

azuresdkci commented Aug 1, 2018

yangyuan commented Aug 2, 2018 • edited Loading

sanjeev3 commented Aug 7, 2018

jhendrixMSFT left a comment

Choose a reason for hiding this comment

yangyuan commented Aug 8, 2018

jhendrixMSFT commented Aug 8, 2018

jhendrixMSFT commented Aug 9, 2018

veronicagg commented Aug 9, 2018

yangyuan commented Aug 10, 2018

jhendrixMSFT left a comment

Choose a reason for hiding this comment

yangyuan commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

AutorestCI commented Jul 25, 2018 •

edited

Loading

yangyuan commented Aug 2, 2018 •

edited

Loading