Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureMonitorExporter] Fix Culture-Specific Formatting of Activity Tags #40000

Merged
merged 7 commits into from
Nov 16, 2023

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes #39470

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left comments about understanding the unit test.

@TimothyMothra
Copy link
Contributor

@rajkumar-rangaraj you're getting AutoRest errors in your ci runs.
I was getting these same errors in my PR.
Locally, I pulled latest of main and merged into my branch and that seemes to have resolved the errors.

@rajkumar-rangaraj rajkumar-rangaraj merged commit a22f40e into Azure:main Nov 16, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUERY] Which number format info should be used by exporter?
3 participants