Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUERY] Which number format info should be used by exporter? #39470

Closed
avereshchak opened this issue Oct 24, 2023 · 2 comments · Fixed by #40000
Closed

[QUERY] Which number format info should be used by exporter? #39470

avereshchak opened this issue Oct 24, 2023 · 2 comments · Fixed by #40000
Assignees
@rajkumar-rangaraj
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@avereshchak
Copy link

avereshchak commented Oct 24, 2023 •
edited
Loading

Library name and version

Azure.Monitor.OpenTelemetry.Exporter 1.0.0

Query/Question

Should the exporter use the NumberFormatInfo from CultureInfo.InvariantCulture for converting activity tags of double/float type?

Currently it is using the CultureInfo.CurrentCulture.

There are a couple consequences:

  • Several tests such as TagObjects_DoubleArray will fail on my PC because the "," character is used as a decimal symbol, not "." as expected by tests.
  • Activity tag values of double type will be converted using different number formats depending on regional settings of a machine running the application being instrumented. If I try convert these values back to double in my Kusto query, I might have to consider all possible decimal symbols, thus making the query more complicated.

Is this an expected behavior of the exporter?

Environment

I'm using the Azure.Monitor.OpenTelemetry.Exporter 1.0.0 in .NET 7.0 console application.
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 24, 2023
@avereshchak avereshchak changed the title [QUERY] [QUERY] Which number format info should be used by exporter? Oct 24, 2023
@jsquire jsquire added Service Attention Workflow: This issue is responsible by Azure service team. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-team-triage Workflow: This issue needs the team to triage. labels Oct 25, 2023
@github-actions
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @reyang @rajkumar-rangaraj @TimothyMothra @vishweshbankwar.

@cijothomas cijothomas added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Oct 25, 2023
@cijothomas
Copy link
Contributor

Looks like unintentional/bug.

@rajkumar-rangaraj rajkumar-rangaraj mentioned this issue Nov 15, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rajkumar-rangaraj rajkumar-rangaraj

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
4 participants
@jsquire @cijothomas @rajkumar-rangaraj @avereshchak