Resolve regressions from proxy-output fix #38752
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @JoshLove-msft I'm mostly free of any fires, so I have some time to apply to this.
First, some context. I resolved an issue with the proxy not properly outputting to stderr when using
logging.error
. However, when I resolved that issue, the next eng/common update actually broke a few additional test cases, because they were checking at the end forstderr
output...and suddenly were getting some! Here is your comment on that sync-common PR at the time.I'm filing this PR now because I have the time to apply fixes to azure-sdk-for-net, and I don't want to maintain a separate version of the proxy that doesn't output to stderr!
First, let's see what melts here.