Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve regressions from proxy-output fix #38752

Closed
wants to merge 1 commit into from

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Sep 15, 2023

Hey @JoshLove-msft I'm mostly free of any fires, so I have some time to apply to this.

First, some context. I resolved an issue with the proxy not properly outputting to stderr when using logging.error. However, when I resolved that issue, the next eng/common update actually broke a few additional test cases, because they were checking at the end for stderr output...and suddenly were getting some! Here is your comment on that sync-common PR at the time.

I'm filing this PR now because I have the time to apply fixes to azure-sdk-for-net, and I don't want to maintain a separate version of the proxy that doesn't output to stderr!

First, let's see what melts here.

@scbedd scbedd self-assigned this Sep 15, 2023
Copy link

Hi @scbedd. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Nov 17, 2023
Copy link

Hi @scbedd. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

More diagnostic information needed when recording syncing fails
1 participant