Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More diagnostic information needed when recording syncing fails #6563

Closed
heaths opened this issue Jul 21, 2023 · 4 comments · Fixed by #6671
Closed

More diagnostic information needed when recording syncing fails #6563

heaths opened this issue Jul 21, 2023 · 4 comments · Fixed by #6671
Assignees
Labels
feature-request This issue requires a new behavior in the product in order be resolved. Test-Proxy Anything relating to test-proxy requests or issues.

Comments

@heaths
Copy link
Member

heaths commented Jul 21, 2023

Related to #6562, it would be great if the test proxy could output more diagnostic information - at least for CIs, if not local dev loops - about what is being sync and any failures that occur. Looking at the failed run, I was not able to tell what had happened. Someone more familiar with the implementation was able to help, but to scale we need more self-diagnosable information available in the CI.

@heaths heaths added feature-request This issue requires a new behavior in the product in order be resolved. Test-Proxy Anything relating to test-proxy requests or issues. labels Jul 21, 2023
@scbedd
Copy link
Member

scbedd commented Jul 21, 2023

Related to #6562, it would be great if the test proxy could output more diagnostic information - at least for CIs, if not local dev loops - about what is being sync and any failures that occur. Looking at the failed run, I was not able to tell what had happened. Someone more familiar with the implementation was able to help, but to scale we need more self-diagnosable information available in the CI.

It definitely outputs it. I'm betting that my ordering of exceptions is off, and that's why you're not getting the initial GitProcessException that shows the actual error that you're expecting.

One recommendation for the .NET CI (aside from addressing this bug) is that it should upload the output of the proxy that we kick as part of the framework. Given the lack of proxy logging I don't really know where to begin to figure out what actually happened here.

@heaths
Copy link
Member Author

heaths commented Jul 21, 2023

Should it just write to stdout or even stderr? I find that tends to be the easiest to diagnose. For example, I saw a couple of git --version commands and outputs. Didn't help for this, but clearly helpful for however needs to know when diagnosing issues.

@scbedd
Copy link
Member

scbedd commented Jul 21, 2023

Should it just write to stdout or even stderr? I find that tends to be the easiest to diagnose. For example, I saw a couple of git --version commands and outputs. Didn't help for this, but clearly helpful for however needs to know when diagnosing issues.

Yeah I think this is the problem right here. We're collecting the stderr -> but we're not outputting it onto StdErr pipe -> so the .NET framework isn't seeing that output on stdErr -> you aren't seeing it in CI.

@JoshLove-msft
Copy link
Member

Addressed on the .NET Test Framework side in Azure/azure-sdk-for-net#37994

@github-project-automation github-project-automation bot moved this from 🐝 Dev to 🎊 Closed in Azure SDK EngSys 🚢🎉 Aug 4, 2023
@scbedd scbedd moved this from 🎊 Closed to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Aug 8, 2023
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requires a new behavior in the product in order be resolved. Test-Proxy Anything relating to test-proxy requests or issues.
Projects
Archived in project
3 participants