Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New .NET SDK for RecoveryServices-DataReplication #38340

Merged
merged 8 commits into from
Sep 16, 2023

Conversation

minhsuanlee
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions
Copy link

Thank you for your contribution @minhsuanlee! We will review the pull request and get back to you soon.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 23, 2023
@minhsuanlee
Copy link
Contributor Author

Skipping "generating samples" and writing scenario tests since this is our very first beta SDK for public preview.

SDK namespace approved as Microsoft.RecoveryServicesDataReplication in https://github.com/Azure/azure-sdk-pr/issues/1220.

Pending for swagger to check-in after ARM's sign-off with Azure/azure-rest-api-specs#24974.

Please go ahead with the review of this PR. It's currently using a swagger PR generated link to swagger and will be replaced and regenerated with official swagger link once swagger PR merged.

@minhsuanlee minhsuanlee force-pushed the recoveryservices-datareplication branch from 7879ca8 to 4992ef2 Compare August 29, 2023 06:10
@ArthurMa1978
Copy link
Member

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ArthurMa1978 ArthurMa1978 added the Mgmt This issue is related to a management-plane library. label Sep 4, 2023
@ArthurMa1978 ArthurMa1978 enabled auto-merge (squash) September 16, 2023 09:04
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@ArthurMa1978 ArthurMa1978 merged commit 790c453 into Azure:main Sep 16, 2023
5 checks passed
yaotongms pushed a commit to yaotongms/azure-sdk-for-net that referenced this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants