[Hub Generated] Review request for Microsoft.DataReplication to add version preview/2021-02-16-preview #24974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @minhsuanlee! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-2021-02-16-preview | package-2021-02-16-preview(c654865) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| The API version:2021-02-16-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.DataReplication/preview/2021-02-16-preview/recoveryservicesdatareplication.json#L6 |
||
| The resource EmailConfigurationModel does not have a corresponding delete operation. Location: Microsoft.DataReplication/preview/2021-02-16-preview/recoveryservicesdatareplication.json#L2988 |
RPC-Delete-V1-05 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
minhsuanlee
requested review from
msyyc,
tadelesh,
jsntcy and
qiaozha
as code owners
8 tasks
This was referenced Jul 25, 2023
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-NewRPNamespaceWithoutRPaaS
new-api-version
new-rp-namespace
resource-manager
WaitForARMFeedback
|
Hi @minhsuanlee This PR was flagged for introducing a new RP namespace that is not being onboarded with RPaaS. Merging this PR to the main branch will be blocked as RPaaS is required for new RPs. To resolve this and allow the PR to be merged into the main branch, please use RPaaS to onboard the new RP. |
|
Hi @minhsuanlee! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
|
Hi, @minhsuanlee, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
This was referenced Jul 25, 2023
|
For LintDiff errors LroErrorContent and OperationsApiResponseSchema, I have taken necessary steps to locally reproduce the errors but from what I can tell, the cause of the error does not seem to be valid as our schema is already following the guidelines. I even tried copy-paste the schema from types.json to our swagger directly and re-run Lint validation, it still failed. In reply to: 1650585436 |
minhsuanlee
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/pr RequestMerge |
minhsuanlee
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@minhsuanlee - Your PR needs to pass required checks before merge. Add the MergeRequested label back after addressing those items. If you get stuck, you can ask for help in the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3a0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%2520Spec%2520Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47. Pinned comments on that channel identify help contacts for SDK breaking change reviewers. |
1 similar comment
|
@minhsuanlee - Your PR needs to pass required checks before merge. Add the MergeRequested label back after addressing those items. If you get stuck, you can ask for help in the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3a0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%2520Spec%2520Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47. Pinned comments on that channel identify help contacts for SDK breaking change reviewers. |
minhsuanlee
force-pushed
the
minhsuanlee-recoveryservicesdatareplication-Microsoft.DataReplication-2021-02-16-preview
branch
from
f8d2dca to
c654865
Compare
minhsuanlee
changed the title
|
/pr RequestMerge |
mentat9
added
Approved-OkToMerge
mentat9
approved these changes
Sep 6, 2023
mentat9
deleted the
minhsuanlee-recoveryservicesdatareplication-Microsoft.DataReplication-2021-02-16-preview
branch
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…ersion preview/2021-02-16-preview (#24974) * Generate new Service for recoveryservicesdatareplication * Initial commit * New version * Fixed LintDiff with common types * Included auto gen net sdk * Addressed some ARM feedback * Updated swagger * Updated and corrected swagger * Addressed PR comments about tags --------- Co-authored-by: Sam Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReviewlabel.ARMReviewlabel, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.