-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing publishing of symbols. Fixing issue# 3518 #3519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro-joowan
pushed a commit
to ro-joowan/azure-sdk-for-net
that referenced
this pull request
Jul 28, 2017
2 tasks
shahabhijeet
pushed a commit
that referenced
this pull request
Aug 4, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Fix Batch changelog references (#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md
shahabhijeet
pushed a commit
that referenced
this pull request
Aug 10, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Fix Batch changelog references (#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts
shahabhijeet
pushed a commit
that referenced
this pull request
Aug 21, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Fix Batch changelog references (#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test
shahabhijeet
pushed a commit
that referenced
this pull request
Aug 29, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1)
shahabhijeet
pushed a commit
that referenced
this pull request
Sep 7, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now
shahabhijeet
pushed a commit
that referenced
this pull request
Sep 13, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now * [BUG FIX] - Making JobInnerError object recursively defined * Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Fix Batch changelog references (Azure#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1)
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now * [BUG FIX] - Making JobInnerError object recursively defined * Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol publishing has recently changed and now need additional information to publish symbols
Fixing issue #3518