Do hydra to swagger specs migration for azure-sdk-for-net #3482

Monicalyy · 2017-07-12T10:51:23Z

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

msftclas · 2017-07-12T10:51:27Z

@Monicalyy,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot #Closed

This reverts commit a33beb0.

shahabhijeet · 2017-07-13T17:06:05Z

@Monicalyy can you provide swagger spec PR link.
Also can you update generate.cmd with the commit Id for the checked in swagger spec.
Also make sure you use latest AutoRest to generate the Authorization SDK

@shahabhijeet About 'Swagger Spec PR link' do you mean this address : https://github.com/Azure/azure-rest-api-specs/tree/master/arm-authorization/2015-07-01/swagger
About generate.cmd, It seems like we don't need to update the specFile, Maybe we need to update the autoRestVersion to the latest version (1.2.0-Nightly20170714)?

#Closed

darshanhs90 · 2017-07-14T00:20:49Z

can you update https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/Authorization/Management.Authorization/Properties/AssemblyInfo.cs with the new version of 2.6.0 #Closed

Monicalyy · 2017-07-17T08:04:17Z

@shahabhijeet Because we compared Hydra and swagger files and found out that we don't need to modify the swagger Json. So we don't have any PR about Swagger.
About generate.cmd, It seems like we don't need to update the specFile, Maybe we need to update the autoRestVersion to the latest version (1.2.0-Nightly20170714) right?
#Closed

shahabhijeet · 2017-07-17T21:56:33Z

@Monicalyy what I am clear is:

why are generating? as I see you are increasing the version number
If you are regenerating, where is the update for the swagger spec?
That is the reason I am asking if you can provide what commit of swagger spec are you generating for?

Also provide a detailed description as to what is the reason for this PR. #Closed

Monicalyy · 2017-07-18T09:14:31Z

@shahabhijeet
Because we received a task to generating Swagger specs from Hydra specs for authorization.
Document says the spec might already be generated, just validate it covers all the API and filters. So After compared Hydra and swagger, We found we don't need to modify the swagger spec. But After generated the swagger specs there has some changes for Authorization project. So we did the test for the changes and created this pull request.
Maybe I did an unintelligible description, So if you have more question, could you contact Haridarshan Hosakere Sudhakar online?

#Closed

darshanhs90 · 2017-07-18T19:10:50Z

@shahabhijeet Maybe there was some confusion regarding updating the assembly file version.
we were under the impression that we need to update the version for every change done to the sdk and publish[rather it be from swagger specs or sdk repo alone]
Since this PR doesnt involve changes to the swagger specs,looks like we dont need to update the version.
Hope that clarifies your queries. #Closed

shahabhijeet

@Monicalyy once the minor update is made, this PR is ready to be merged.

shahabhijeet · 2017-07-19T18:07:27Z

src/SDKs/Authorization/Authorization.Tests/Authorization.Tests.csproj

@@ -20,6 +20,9 @@
  </ItemGroup>

  <ItemGroup>
+    <None Update="SessionRecords\Authorization.Tests.BasicTests\ProviderOperationsMetadataListGetTests.json">


@Monicalyy please replace all these lines with something like below.
This helps in maintaining project files concise.
< ItemGroup>
< None Update="SessionRecords \ ** \ *.json">
< CopyToOutputDirectory>PreserveNewest< /CopyToOutputDirectory>
< /None>
< /ItemGroup>
#Closed

@shahabhijeet I have finished the change. Please review.

shahabhijeet · 2017-07-20T20:31:52Z

@azuresdkci test this please

darshanhs90 · 2017-07-20T21:44:34Z

src/SDKs/Authorization/Authorization.Tests/Tests/BasicTests.cs

+                Assert.NotNull(providerOperationsMetadata.Name);
+                Assert.NotNull(providerOperationsMetadata.Operations);
+                Assert.NotNull(providerOperationsMetadata.ResourceTypes);
+                Assert.NotNull(providerOperationsMetadata.Type);


can you add a negative test for this get method?
One with an invalid Provider and another with an invalid API version

shahabhijeet · 2017-07-20T23:33:21Z

@darshanhs90 can you use the code review tool to request for change. This way it shows red cross next to your name. Once you approve only then I will merge.

darshanhs90 · 2017-07-24T23:07:15Z

@Monicalyy could you update the tests,so that we can finish this PR

shahabhijeet · 2017-07-27T16:14:28Z

@azuresdkci test this please

shahabhijeet · 2017-07-27T16:19:52Z

once the CI passes this is good to merge

shahabhijeet · 2017-07-27T16:33:12Z

@azuresdkci test this please

shahabhijeet · 2017-07-27T17:06:22Z

@Monicalyy Authorization tests have failed.
I had disabled all Authorization tests so far, so today I enabled them back and they started failing.

shahabhijeet · 2017-07-27T21:23:06Z

@azuresdkci test this please

* Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Fix Batch changelog references (#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Fix Batch changelog references (#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Fix Batch changelog references (#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1)

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (#3513) * Fixing publishing of symbols. Fixing issue# 3518 (#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now * [BUG FIX] - Making JobInnerError object recursively defined * Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Fix Batch changelog references (Azure#3517) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1)

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now * [BUG FIX] - Making JobInnerError object recursively defined * Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member

Do hydra to swagger specs migration for azure-sdk-for-net

2e92f47

msftclas added the cla-required label Jul 12, 2017

Monicalyy added cla-not-required and removed cla-required labels Jul 12, 2017

Monica Lin added 2 commits July 13, 2017 10:53

Fix build failed problem

e853918

update the assemblyinfo file with the updated version 2.6.0

a33beb0

Monicalyy requested a review from darshanhs90 July 13, 2017 03:32

Revert "update the assemblyinfo file with the updated version 2.6.0"

0e853c5

This reverts commit a33beb0.

shahabhijeet added the needs-revision label Jul 13, 2017

Updata the AssemblyFileVersion to 2.6.0.0

b5add44

revert package version

3389572

shahabhijeet suggested changes Jul 19, 2017

View reviewed changes

Make project files concise.

bf2ad51

Monicalyy added the needs-review label Jul 20, 2017

darshanhs90 reviewed Jul 20, 2017

View reviewed changes

Monicalyy and others added 2 commits July 26, 2017 14:57

Add Provider test case

0ea9ed1

update the pr with new tests with session records

a1a1cf1

shahabhijeet removed the needs-revision label Jul 27, 2017

shahabhijeet added needs-revision and removed needs-review labels Jul 27, 2017

remove extra code

f2bd886

darshanhs90 added needs-review and removed needs-revision labels Jul 27, 2017

shahabhijeet approved these changes Jul 27, 2017

View reviewed changes

shahabhijeet merged commit fa80f08 into psSdkJson6 Jul 27, 2017

shahabhijeet deleted the Private-Authorization-Second branch August 4, 2017 23:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do hydra to swagger specs migration for azure-sdk-for-net #3482

Do hydra to swagger specs migration for azure-sdk-for-net #3482

Monicalyy commented Jul 12, 2017 •

edited

Loading

msftclas commented Jul 12, 2017 •

edited by darshanhs90

Loading

shahabhijeet commented Jul 13, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Jul 14, 2017 •

edited

Loading

Monicalyy commented Jul 17, 2017 •

edited by darshanhs90

Loading

shahabhijeet commented Jul 17, 2017 •

edited by darshanhs90

Loading

Monicalyy commented Jul 18, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Jul 18, 2017 •

edited

Loading

shahabhijeet left a comment

shahabhijeet Jul 19, 2017 •

edited by darshanhs90

Loading

Monicalyy Jul 20, 2017

shahabhijeet commented Jul 20, 2017

darshanhs90 Jul 20, 2017 •

edited

Loading

shahabhijeet commented Jul 20, 2017

darshanhs90 commented Jul 24, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

Do hydra to swagger specs migration for azure-sdk-for-net #3482

Do hydra to swagger specs migration for azure-sdk-for-net #3482

Conversation

Monicalyy commented Jul 12, 2017 • edited Loading

Description

General Guidelines

Testing Guidelines

SDK Generation Guidelines

msftclas commented Jul 12, 2017 • edited by darshanhs90 Loading

shahabhijeet commented Jul 13, 2017 • edited by darshanhs90 Loading

darshanhs90 commented Jul 14, 2017 • edited Loading

Monicalyy commented Jul 17, 2017 • edited by darshanhs90 Loading

shahabhijeet commented Jul 17, 2017 • edited by darshanhs90 Loading

Monicalyy commented Jul 18, 2017 • edited by darshanhs90 Loading

darshanhs90 commented Jul 18, 2017 • edited Loading

shahabhijeet left a comment

Choose a reason for hiding this comment

shahabhijeet Jul 19, 2017 • edited by darshanhs90 Loading

Choose a reason for hiding this comment

Monicalyy Jul 20, 2017

Choose a reason for hiding this comment

shahabhijeet commented Jul 20, 2017

darshanhs90 Jul 20, 2017 • edited Loading

Choose a reason for hiding this comment

shahabhijeet commented Jul 20, 2017

darshanhs90 commented Jul 24, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

shahabhijeet commented Jul 27, 2017

Monicalyy commented Jul 12, 2017 •

edited

Loading

msftclas commented Jul 12, 2017 •

edited by darshanhs90

Loading

shahabhijeet commented Jul 13, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Jul 14, 2017 •

edited

Loading

Monicalyy commented Jul 17, 2017 •

edited by darshanhs90

Loading

shahabhijeet commented Jul 17, 2017 •

edited by darshanhs90

Loading

Monicalyy commented Jul 18, 2017 •

edited by darshanhs90

Loading

darshanhs90 commented Jul 18, 2017 •

edited

Loading

shahabhijeet Jul 19, 2017 •

edited by darshanhs90

Loading

darshanhs90 Jul 20, 2017 •

edited

Loading