Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignalR] Add Strongly typed serverless hub #25075

Merged
4 commits merged into from
Nov 17, 2021
Merged

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Nov 2, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Y-Sindo Y-Sindo changed the title Strongly typed hub [SignalR] Add Strongly typed serverless hub Nov 2, 2021
@Y-Sindo Y-Sindo added the SignalR label Nov 8, 2021
@Y-Sindo Y-Sindo marked this pull request as ready for review November 9, 2021 07:30
@Y-Sindo Y-Sindo marked this pull request as draft November 9, 2021 07:41
@azure-sdk
Copy link
Collaborator

API changes have been detected in Microsoft.Azure.WebJobs.Extensions.SignalRService. You can review API changes here

API changes

+     public abstract class ServerlessHub<T> where T : class {
+         protected ServiceHubContext<T> HubContext { get; }
+         protected static IList<Claim> GetClaims(string jwt);
+         protected ValueTask<SignalRConnectionInfo> NegotiateAsync(NegotiationOptions options);
+     }

@Azure Azure deleted a comment from azure-sdk Nov 9, 2021
@Y-Sindo Y-Sindo marked this pull request as ready for review November 9, 2021 09:44
@ghost
Copy link

ghost commented Nov 16, 2021

Hello @Y-Sindo!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Y-Sindo
Copy link
Member Author

Y-Sindo commented Nov 16, 2021

/check-enforcer reset

@azure-sdk
Copy link
Collaborator

API changes have been detected in Microsoft.Azure.WebJobs.Extensions.SignalRService. You can review API changes here

API changes

+     public abstract class ServerlessHub<T> where T : class {
+         protected ServerlessHub(ServiceHubContext<T> serviceHubContext = null);
+         public ClientManager ClientManager { get; }
+         public IHubClients<T> Clients { get; }
+         public GroupManager Groups { get; }
+         public UserGroupManager UserGroups { get; }
+         protected static IList<Claim> GetClaims(string jwt);
+         protected Task<SignalRConnectionInfo> NegotiateAsync(NegotiationOptions options);
+     }

@Y-Sindo
Copy link
Member Author

Y-Sindo commented Nov 16, 2021

/check-enforcer reset

@ghost ghost merged commit e24341e into Azure:main Nov 17, 2021
@Y-Sindo Y-Sindo deleted the stronglyTypedHub branch November 17, 2021 07:17
yukun-dong added a commit that referenced this pull request Nov 19, 2021
* [SignalR] Add Strongly typed serverless hub (#25075)

# All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.
- [x] **Please open PR in `Draft` mode if it is:**
	- Work in progress or not intended to be merged.
	- Encountering multiple pipeline failures and working on fixes.
- [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).**
- [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).**

### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines)
- [x] Title of the pull request is clear and informative.
- [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md).

### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines)
- [x] Pull request includes test coverage for the included changes.

* Increment version for operationalinsights releases (#25345)

Increment package version after release of Microsoft.Azure.OperationalInsights

* [ACR] Update SDK to c8d9a26a of REST spec (#24341)

* Generate changes before any transforms

* Regenerate code after adding transforms

* Update internal interface and cleanup removed properties

* Update public API

* Update service version and test session records

* Fix params for `ExchangeAadAccessTokenForAcrRefreshToken()`
Set `GrantType` as `AccessToken`. `tenant` and `refreshToken` are null.

* Update public API

* Update session records

* Update Changelog

* Sync eng/common directory with azure-sdk-tools for PR 2290 (#25372)

* update docker-start-proxy to have a slightly different default parameter

* we were surrounding the value in single quotes, breaking recording load

Co-authored-by: scbedd <[email protected]>

* [Event Hubs] Flaky Test Fix (#25346)

The focus of these changes is to stabilize some tests with non-deterministic
behavior that have recently shown to be flaky when run in CI pipelines.

* [Azure.Core] Logging Sample Enhancement (#25389)

# Summary

The focus of these changes is to enhance the logging section of the diagnostics sample to include details about the lifetime of the `AzureEventSourceListener`.  We received some customer feedback that it was unclear where they needed to create the listener and that it had to have the appropriate scope to be able to capture logs.

* [LLC] Implement RequestOptions.AddPolicy (#25214)

* add test for AddPolicy

* share proposed refactoring to HttpPipelineExtensions

* ideas in the direction of implementation

* mark retry policy

* revert mark retry policy

* shifting API around

* experiment with using MemoryPool

* use ArrayPool

* use ArrayPool

* add tests

* update API

* throw if didn't use pipeline builder

* pr feedback and merge follow-up

* pr fb and merge follow-up

* pr fb

* simplify request pipeline creation

* move AddPolicy tests to Core; pr fb

* nit

* pr fb

* pr fb & fix build

* pr fb

* pr fb & build fix

* pr fb

* pr fb

* pr fb & fix core ci

* Update CODEOWNERS (#25393)

* Microsoft.Azure.Management.Avs 3.0.0 (#25276)

* use main branch

* generated for 2021-12-01 API

* switch AvsTests to test mock_api server

* Updating recorded test files also tested with playback

* generate from main

* set to 3.0.0

* Updating test records for AVS/2021-12

* Updating new test records

* Updated test records

Co-authored-by: Pinak Kelkar <[email protected]>

* KeyVault Preview 2021 06 (#25282)

* Generated new code from 06-preview version

* Regenerated code to pick up additional changes.

* Update unit tests for 2021-06-01-preview and SystemData

* updated metadata

* Updated package version to 4.0.0-preview.1

Co-authored-by: Soohwan Kim <[email protected]>
Co-authored-by: Jiacheng Liu <[email protected]>

* Increment version for containerregistry releases (#25397)

Increment package version after release of Azure.Containers.ContainerRegistry

* Add storage mgmt test (#25395)

* add tests from track1

* add and modify some tests

add tests

modify tests

* ignore PITR test case

* ignore PrivateEndpointConnection tests

* Update changelog for AddPolicy (#25394)

* [Event Hubs] Sample updates for the Buffered Producer (#25388)

* [Event Hubs] Sample updates for the Buffered Producer

The focus of these changes is to incorporate the `EventHubBufferedProducer`
client into the Event Hubs samples for client types and publishing.  Also
included is a clarification for the logging sample, calling out the lifetime
needs for the listener.

* TURN: Adding RouteType optional parameter to GetRelayConfiguration (#25032)

* Add Anycast parameter to GetRelayConfiguration

* Update PR, removing unused snippet.

* Modified swagger, so adding new autogenerated code

* Update PR

* Update PR, add new recordings, reenable non-identity tests

* Adding GetRelayOptions and updating Readme and changelog

* Update PR

* Update PR

* [MetricsAdvisor] Add tests for Skip and MaximumPageSize input options in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests (#24540)

* Fix CanSetContentLengthOverMaxInt (#25404)

* Update changelog removing unused sections (#25413)

* [template-LLC] Rename LLC to Dataplane Code Gen (#25390)

* Rename LLC to Dataplane Code Gen

* [Event Hubs] Buffered Producer Tweaks and Test Fixes (#25415)

The focus of these changes is to trim some unused logic for enqueuing events,
add some missing mock setups to guard against a test race, and improve some
minor test structure.

* Fix Broken link in EventGrid ReadMe (#25417)

* [MetricsAdvisor] Moving to new MA resource (#25406)

* Add Bryce into CodeOwners for IoT SDK team (#25420)

* fix test error; update snippets

Co-authored-by: yzt <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: scbedd <[email protected]>
Co-authored-by: Jesse Squire <[email protected]>
Co-authored-by: Anne Thompson <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>
Co-authored-by: Cameron Taggart <[email protected]>
Co-authored-by: Pinak Kelkar <[email protected]>
Co-authored-by: kim-soohwan <[email protected]>
Co-authored-by: Soohwan Kim <[email protected]>
Co-authored-by: Jiacheng Liu <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: Gyeonghun Park <[email protected]>
Co-authored-by: Pavel Krymets <[email protected]>
Co-authored-by: ShivangiReja <[email protected]>
Co-authored-by: Chidozie Ononiwu (His Righteousness) <[email protected]>
Co-authored-by: Caio Saldanha <[email protected]>
Co-authored-by: brycewang-microsoft <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants