[MetricsAdvisor] Add tests for Skip and MaximumPageSize input options in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests #24540
Conversation
ghost
added
Cognitive - Metrics Advisor
customer-reported
|
Thank you for your contribution @Gyeonghun-Park! We will review the pull request and get back to you soon. |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
...etricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs
Outdated
Show resolved
Hide resolved
...etricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs
Outdated
Show resolved
Hide resolved
...etricsAdvisor/tests/MetricsAdvisorAdministrationClient/AnomalyAlertConfigurationLiveTests.cs
Outdated
Show resolved
Hide resolved
|
If you don't mind, could you review the records for those tests? Although I have generated records, they may not be perfect because they are based on my personal server, not on js-metrics-advisor server. |
Records look good! Recorded tests are run as part of PR validation, so they should be working fine if the PR checks passed. |
|
There's some Metrics Advisor parallel work going on right now. I'm merging this so you don't have to deal with merge conflicts that will likely emerge. Feel free to open a new PR or an issue if you feel we missed anything on this one. |
* [SignalR] Add Strongly typed serverless hub (#25075) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [x] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [x] Pull request includes test coverage for the included changes. * Increment version for operationalinsights releases (#25345) Increment package version after release of Microsoft.Azure.OperationalInsights * [ACR] Update SDK to c8d9a26a of REST spec (#24341) * Generate changes before any transforms * Regenerate code after adding transforms * Update internal interface and cleanup removed properties * Update public API * Update service version and test session records * Fix params for `ExchangeAadAccessTokenForAcrRefreshToken()` Set `GrantType` as `AccessToken`. `tenant` and `refreshToken` are null. * Update public API * Update session records * Update Changelog * Sync eng/common directory with azure-sdk-tools for PR 2290 (#25372) * update docker-start-proxy to have a slightly different default parameter * we were surrounding the value in single quotes, breaking recording load Co-authored-by: scbedd <[email protected]> * [Event Hubs] Flaky Test Fix (#25346) The focus of these changes is to stabilize some tests with non-deterministic behavior that have recently shown to be flaky when run in CI pipelines. * [Azure.Core] Logging Sample Enhancement (#25389) # Summary The focus of these changes is to enhance the logging section of the diagnostics sample to include details about the lifetime of the `AzureEventSourceListener`. We received some customer feedback that it was unclear where they needed to create the listener and that it had to have the appropriate scope to be able to capture logs. * [LLC] Implement RequestOptions.AddPolicy (#25214) * add test for AddPolicy * share proposed refactoring to HttpPipelineExtensions * ideas in the direction of implementation * mark retry policy * revert mark retry policy * shifting API around * experiment with using MemoryPool * use ArrayPool * use ArrayPool * add tests * update API * throw if didn't use pipeline builder * pr feedback and merge follow-up * pr fb and merge follow-up * pr fb * simplify request pipeline creation * move AddPolicy tests to Core; pr fb * nit * pr fb * pr fb & fix build * pr fb * pr fb & build fix * pr fb * pr fb * pr fb & fix core ci * Update CODEOWNERS (#25393) * Microsoft.Azure.Management.Avs 3.0.0 (#25276) * use main branch * generated for 2021-12-01 API * switch AvsTests to test mock_api server * Updating recorded test files also tested with playback * generate from main * set to 3.0.0 * Updating test records for AVS/2021-12 * Updating new test records * Updated test records Co-authored-by: Pinak Kelkar <[email protected]> * KeyVault Preview 2021 06 (#25282) * Generated new code from 06-preview version * Regenerated code to pick up additional changes. * Update unit tests for 2021-06-01-preview and SystemData * updated metadata * Updated package version to 4.0.0-preview.1 Co-authored-by: Soohwan Kim <[email protected]> Co-authored-by: Jiacheng Liu <[email protected]> * Increment version for containerregistry releases (#25397) Increment package version after release of Azure.Containers.ContainerRegistry * Add storage mgmt test (#25395) * add tests from track1 * add and modify some tests add tests modify tests * ignore PITR test case * ignore PrivateEndpointConnection tests * Update changelog for AddPolicy (#25394) * [Event Hubs] Sample updates for the Buffered Producer (#25388) * [Event Hubs] Sample updates for the Buffered Producer The focus of these changes is to incorporate the `EventHubBufferedProducer` client into the Event Hubs samples for client types and publishing. Also included is a clarification for the logging sample, calling out the lifetime needs for the listener. * TURN: Adding RouteType optional parameter to GetRelayConfiguration (#25032) * Add Anycast parameter to GetRelayConfiguration * Update PR, removing unused snippet. * Modified swagger, so adding new autogenerated code * Update PR * Update PR, add new recordings, reenable non-identity tests * Adding GetRelayOptions and updating Readme and changelog * Update PR * Update PR * [MetricsAdvisor] Add tests for Skip and MaximumPageSize input options in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests (#24540) * Fix CanSetContentLengthOverMaxInt (#25404) * Update changelog removing unused sections (#25413) * [template-LLC] Rename LLC to Dataplane Code Gen (#25390) * Rename LLC to Dataplane Code Gen * [Event Hubs] Buffered Producer Tweaks and Test Fixes (#25415) The focus of these changes is to trim some unused logic for enqueuing events, add some missing mock setups to guard against a test race, and improve some minor test structure. * Fix Broken link in EventGrid ReadMe (#25417) * [MetricsAdvisor] Moving to new MA resource (#25406) * Add Bryce into CodeOwners for IoT SDK team (#25420) * fix test error; update snippets Co-authored-by: yzt <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: Mohit Chakraborty <[email protected]> Co-authored-by: scbedd <[email protected]> Co-authored-by: Jesse Squire <[email protected]> Co-authored-by: Anne Thompson <[email protected]> Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Cameron Taggart <[email protected]> Co-authored-by: Pinak Kelkar <[email protected]> Co-authored-by: kim-soohwan <[email protected]> Co-authored-by: Soohwan Kim <[email protected]> Co-authored-by: Jiacheng Liu <[email protected]> Co-authored-by: AriZavala2 <[email protected]> Co-authored-by: Gyeonghun Park <[email protected]> Co-authored-by: Pavel Krymets <[email protected]> Co-authored-by: ShivangiReja <[email protected]> Co-authored-by: Chidozie Ononiwu (His Righteousness) <[email protected]> Co-authored-by: Caio Saldanha <[email protected]> Co-authored-by: brycewang-microsoft <[email protected]>
Changes:
Part of #20621