Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for Scanning #24305

Closed
wants to merge 2 commits into from
Closed

add test for Scanning #24305

wants to merge 2 commits into from

Conversation

liurunliang
Copy link

add test for Scanning and make GetDataSourceClient() and GetClassificationRuleClient() virtual

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@liurunliang
add test for Scanning
8c56881 
add test for scanning and make GetDataSourceClient() and GetClassificationRuleClient() virtual
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 29, 2021
@ghost
Copy link

ghost commented Sep 29, 2021

Thank you for your contribution @liurunliang! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Sep 29, 2021
@liurunliang
update project with export-api.ps1
19a323c 
update project with export-api.ps1 after changing method in PurviewScanningServiceClient.cs
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Aug 23, 2023
@guptanitish-ms @lobashh
@SharanSingh @Aleksand4rZivanovic @a-lazarlazic @mykolian @srnanikolicmdcs @rebeccaxu-ms @LeiWang3 @viparek @nmirkovic-microsoft @pmahanandire @Nidhi-Gupta6198
CodeGen from PR 25293 in Azure/azure-rest-api-specs
ee6d6f8 
Release sql microsoft.sql 2023 02 01 preview (Azure#25293)

* Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* add mi refresh API (Azure#24093)

* add mi refresh API

* remove stray character

* add examples

* fix lro error

* fix lro error only in example

* fixing prettier issue

* Test commit - adding error schema

* Test2

* Test - changing error type

* Revert "Test - changing error type"

This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064.

* Reverting 3 test commits

* Test - adding commong error type reference

* fix type format errors

---------

Co-authored-by: Stefan Krivokapic <[email protected]>

* Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221)

* Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132)

* Added the swagger spec and example json files for failvoer group API update in V2023-020-1

* Corrected the FailoverGroupGet.json example

* Updated the auto-generated FailoverGroups.json

Fixed FailoverGroups.json swagger arm-id attribute for databases field

* Added the missing headers field manually

* Fix FailoverGroups.json

---------

Co-authored-by: Sharan Singh <[email protected]>

* Changes to Location Capabilities (Azure#24209)

* Loc cap changes

* removing changes not related to my changes in dsmain

* DAG API 2023-02-01 (#24108)

* add new dag api version

* Update swagger

* Update swagger

* patch resource

* make replicationMode writable

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224)

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API

* Change property from name to exhaustionBehaviorType

* generate swagger for LocationCapabilites (Azure#24290)

* inital commit for LTR Policy Immutability (Azure#24347)

* inital commit for immutable ltr backups (Azure#24349)

* Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305)

* Update swagger files for Server API

* Add v5 tag for Servers

* Restore none for minimal TLS version

* Add auto rotation param to databases api (Azure#24339)

* Add auto rotation param to databases api

* add armid

* Adding IsFreemium and CreateTime to Get MI API (Azure#24239)

* Updated the examples for LTR Policies and LTR Backups (Azure#24821)

* Updated the examples for LTR Policies and LTR Backups

* Not sure why makeBackupsImmutable got deleted

* updating swagger files for enum name changes (Azure#24742)

* Carrying over minor changes for the 2023-02-01-preview release (Azure#25177)

* Carrying over minor changes for the 2023-02-01-preview release

* Reverting example files that didn't have DsMainDev side changes, and fixing prettier check

* Fixes for LTR examples with model validation and prettier check for ServerDelete

* Reverting LTR changes

* Adding arm-id to serversjson

* swagger changes for adding new parameter in dc telemetry (Azure#24834)

* testing push

* reverting push

* swagger files for DC add parameter change

* delete added file

* modified swagger files without Venkat's change

* modified swagger files

* changed modelAsString to true

* add example files

* add example files

* fix mismatch

* Removing Pattern from ManagedInstance to avoid incident  (Azure#25295)

* Carrying over minor changes for the 2023-02-01-preview release

* Reverting example files that didn't have DsMainDev side changes, and fixing prettier check

* Fixes for LTR examples with model validation and prettier check for ServerDelete

* Reverting LTR changes

* Adding arm-id to serversjson

* Removing the Pattern property from ManagedInstances.json as it should not be present and will cause issues in downstream client generation

---------

Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>
Co-authored-by: pmahanandire <[email protected]>
Co-authored-by: nidhigupta <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Oct 27, 2023
@jacobopac @guptanitish-ms
@lobashh @SharanSingh @Aleksand4rZivanovic @a-lazarlazic @mykolian @srnanikolicmdcs @rebeccaxu-ms @LeiWang3 @viparek @nmirkovic-microsoft @ms-mjovkovic @rayboyd30 @kosta-bizetic @CelinaJiangJXY @Yashu1818 @sonjaciric @nesavicMSFT @alejandro182 @saljain0101 @mmilovanovic95 @archanasahoo22
CodeGen from PR 26289 in Azure/azure-rest-api-specs
f6d276f 
Release sql microsoft.sql 2023 05 01 preview (Azure#26289)

* Adds base for updating Microsoft.Sql from version preview/2023-02-01-preview to version 2023-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding JobPrivateEndpoints API to version 2023-05-01-preview  (Azure#24902)

* Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* add mi refresh API (Azure#24093)

* add mi refresh API

* remove stray character

* add examples

* fix lro error

* fix lro error only in example

* fixing prettier issue

* Test commit - adding error schema

* Test2

* Test - changing error type

* Revert "Test - changing error type"

This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064.

* Reverting 3 test commits

* Test - adding commong error type reference

* fix type format errors

---------

Co-authored-by: Stefan Krivokapic <[email protected]>

* Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221)

* Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132)

* Added the swagger spec and example json files for failvoer group API update in V2023-020-1

* Corrected the FailoverGroupGet.json example

* Updated the auto-generated FailoverGroups.json

Fixed FailoverGroups.json swagger arm-id attribute for databases field

* Added the missing headers field manually

* Fix FailoverGroups.json

---------

Co-authored-by: Sharan Singh <[email protected]>

* Changes to Location Capabilities (Azure#24209)

* Loc cap changes

* removing changes not related to my changes in dsmain

* DAG API 2023-02-01 (#24108)

* add new dag api version

* Update swagger

* Update swagger

* patch resource

* make replicationMode writable

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224)

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API

* Change property from name to exhaustionBehaviorType

* generate swagger for LocationCapabilites (Azure#24290)

* inital commit for LTR Policy Immutability (Azure#24347)

* inital commit for immutable ltr backups (Azure#24349)

* Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305)

* Update swagger files for Server API

* Add v5 tag for Servers

* Restore none for minimal TLS version

* Add auto rotation param to databases api (Azure#24339)

* Add auto rotation param to databases api

* add armid

* Adding IsFreemium and CreateTime to Get MI API (Azure#24239)

* job private endpoint swagger

* rerun pipelines

* adding job private endpoints to readme

* rerun pipelines

* trying to fix lint errors

* fixing typos - singular resource name and description.

* adding arm-id

* Moving files to the new version; no changes to the files themselves.

* adding job agent private endpoints to readme

---------

Co-authored-by: Jeremy Frosti <[email protected]>
Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>

* DAG API 2023-05-01 for MI First (Azure#25638)

* mi first dag api 2023-05-01

* adding x-ms-identifiers

* adding job step and target group apis to version 2023-05-01-preview (Azure#25689)

* adding job step and target group apis to versoin 2023-05-01-preview

* remove required credential

---------

Co-authored-by: Ray Boyd <[email protected]>

* updating location capabilities for 2023-05-01-preview (Azure#25539)

Co-authored-by: Ray Boyd <[email protected]>

* Updating Instance Pool swagger for 2023-05-01-preview (Azure#25580)

* Updating Instance Pool swagger for 2023-05-01-preview

* Add format specification

* Update examples

---------

Co-authored-by: Kosta Bizetic <[email protected]>
Co-authored-by: Ivan Arandjelovic <[email protected]>

* Add Archive option to LTR Policy and LTR Backup for SQL DB  (Azure#25799)

* added changes

* fix swagger validation failures

* adding fixes

* added more changes

* added fixes

* fixed LintDiff

* added changes

* fix lintDiff

* Swagger validations for serverless parameters added in SQL API (Azure#25852)

* Swagger validations for serverless parameters added in SQL API

* Fixing spellcheck in example file

* Fix LintDiff error

---------

Co-authored-by: Yash Udasi <[email protected]>

* Add AAD support to job agents version 2023-05-01-preview (Azure#25553)

* adding job agent identity support to 2023-05-01-preview

* updated swagger with just aad changes

---------

Co-authored-by: Ray Boyd <[email protected]>

* Dev/sonjac/ltr api update (Azure#25701)

* Adding generated files.

* Fixing swagger errors.

* Managed Instance swagger to support Authentication Metadata (Azure#25795)

* generated swagger

* fixed prettier:

* fixed minor stuff

* swagger fixes

* added missing example file

* removed unused file

* externalgovernance fixes

* minor fixes

* missing character

* Adding JobAgents API with SKU support to version 2023-05-01-preview (Azure#24995)

* Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* add mi refresh API (Azure#24093)

* add mi refresh API

* remove stray character

* add examples

* fix lro error

* fix lro error only in example

* fixing prettier issue

* Test commit - adding error schema

* Test2

* Test - changing error type

* Revert "Test - changing error type"

This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064.

* Reverting 3 test commits

* Test - adding commong error type reference

* fix type format errors

---------

Co-authored-by: Stefan Krivokapic <[email protected]>

* Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221)

* Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132)

* Added the swagger spec and example json files for failvoer group API update in V2023-020-1

* Corrected the FailoverGroupGet.json example

* Updated the auto-generated FailoverGroups.json

Fixed FailoverGroups.json swagger arm-id attribute for databases field

* Added the missing headers field manually

* Fix FailoverGroups.json

---------

Co-authored-by: Sharan Singh <[email protected]>

* Changes to Location Capabilities (Azure#24209)

* Loc cap changes

* removing changes not related to my changes in dsmain

* DAG API 2023-02-01 (#24108)

* add new dag api version

* Update swagger

* Update swagger

* patch resource

* make replicationMode writable

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224)

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API

* Change property from name to exhaustionBehaviorType

* generate swagger for LocationCapabilites (Azure#24290)

* inital commit for LTR Policy Immutability (Azure#24347)

* inital commit for immutable ltr backups (Azure#24349)

* Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305)

* Update swagger files for Server API

* Add v5 tag for Servers

* Restore none for minimal TLS version

* Add auto rotation param to databases api (Azure#24339)

* Add auto rotation param to databases api

* add armid

* Adding IsFreemium and CreateTime to Get MI API (Azure#24239)

* Updated the examples for LTR Policies and LTR Backups (Azure#24821)

* Updated the examples for LTR Policies and LTR Backups

* Not sure why makeBackupsImmutable got deleted

* swagger changes

* api version changed

* adding identity files to the version on review

* change of getjobagent

* change test

* nit fix

* Changes to use SKU name to specify SLO

* Changes for job agent update SLO with 2023-05-01 version

* removing files of 2023-02-01

* fix

* removing changes on JobAgents 2023-02-01

---------

Co-authored-by: Jeremy Frosti <[email protected]>
Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>

* added swagger spec and example json files for failovergroup api (Azure#25837)

* Updating Managed Instance swagger for 2023-05-01-preview (Azure#26098)

* Modifying ManagedInstances.json and corresponding examples

* Remove example

* Fix syntax errors

* Swagger API changes to support PUT and PATCH to update replication link type (Azure#25690)

* Add Swagger files for Replication Link Update Link Type

* resolve validation error

* Modify property description

* resolve lint errors

* Reverting MI change for readme to fix merge conflict with main (Azure#26296)

---------

Co-authored-by: jacobopac <[email protected]>
Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>
Co-authored-by: ms-mjovkovic <[email protected]>
Co-authored-by: Ray Boyd <[email protected]>
Co-authored-by: Ray Boyd <[email protected]>
Co-authored-by: Kosta Bizetić <[email protected]>
Co-authored-by: Kosta Bizetic <[email protected]>
Co-authored-by: Ivan Arandjelovic <[email protected]>
Co-authored-by: CelinaJiangJXY <[email protected]>
Co-authored-by: Yash Udasi <[email protected]>
Co-authored-by: Yash Udasi <[email protected]>
Co-authored-by: Sonja Ciric <[email protected]>
Co-authored-by: Nebojsa Savic <[email protected]>
Co-authored-by: alejandro182 <[email protected]>
Co-authored-by: saljain0101 <[email protected]>
Co-authored-by: Marko Milovanovic <[email protected]>
Co-authored-by: Archana Sahoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGhiondea AlexGhiondea Awaiting requested review from AlexGhiondea

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@liurunliang